Skip to content

[4.7.5] Fix --page: dropped last measure in page export#34135

Open
RomanPudashkin wants to merge 1 commit into
musescore:4.7from
RomanPudashkin:fix_cli_page_option_47
Open

[4.7.5] Fix --page: dropped last measure in page export#34135
RomanPudashkin wants to merge 1 commit into
musescore:4.7from
RomanPudashkin:fix_cli_page_option_47

Conversation

@RomanPudashkin

Copy link
Copy Markdown
Contributor

No description provided.

@RomanPudashkin RomanPudashkin added the cli Issues related to MuseScore's command line interface label Jul 9, 2026
@RomanPudashkin

Copy link
Copy Markdown
Contributor Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Full review finished.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 60dbcec8-1414-4cbc-b01a-4a43b0f3e9b8

📥 Commits

Reviewing files that changed from the base of the PR and between 7688c00 and 36b68c5.

📒 Files selected for processing (1)
  • src/project/internal/notationproject.cpp

📝 Walkthrough

Walkthrough

This change modifies NotationProject::savePage in notationproject.cpp. The write range's endMeasure is now set to the measure following the last measure of the page (systems.back()->last()->next(), falling back to nullptr if none), rather than the last measure itself. A new include for engraving/dom/measurebase.h was added to support this change.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is missing, so the required template fields and checklist items are not provided. Add the template sections, including a Resolves issue reference, a short summary, and the checklist items completed with relevant testing notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: fixing the --page export flow dropping the last measure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@RomanPudashkin RomanPudashkin requested a review from Eism July 9, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli Issues related to MuseScore's command line interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants