Skip to content

[4.7.5] Fix --page: dropped last measure in page export #34135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RomanPudashkin merged 1 commit into from
Jul 16, 2026
+5 −1
Merged

[4.7.5] Fix --page: dropped last measure in page export #34135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/project/internal/notationproject.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
#include "engraving/compat/engravingcompat.h"
#include "engraving/dom/excerpt.h"
#include "engraving/dom/masterscore.h"
#include "engraving/dom/measurebase.h"
#include "engraving/dom/repeatlist.h"
#include "engraving/editing/editscoreproperties.h"
#include "engraving/engravingerrors.h"
Expand Down Expand Up @@ -578,7 +579,10 @@ muse::Ret NotationProject::savePage(const muse::io::path_t& path, const size_t p
range.startStaffIdx = 0;
range.endStaffIdx = score->nstaves();
range.startMeasure = systems.front()->first();
range.endMeasure = systems.back()->last();
// StaffWrite::writeStaff stops before reaching endMeasure, so use the measure after
// the last one we want, otherwise the page's last measure/frame is dropped
MeasureBase* lastMeasure = systems.back()->last();
range.endMeasure = lastMeasure ? lastMeasure->next() : nullptr;

write::WriteContext ctx(score);
ctx.setRange(range);
Expand Down
Loading