Dedupe identical vulkan_sdk toolchain tags across modules#150
Merged
Conversation
A module extension is evaluated once per build and receives the toolchain tags of every module that used it. When two modules request the same SDK version (e.g. a library and the app consuming it both pin 1.4.341.1), both tags resolve to the same repository name and install_sdk fails with a "repository already defined" error, breaking any multi-module graph that shares an SDK. Dedupe by the resolved repository name so identical requests collapse to a single repo. When the same name is requested with different attributes -- a genuine conflict between two distinct SDKs -- fail with an actionable message telling the user to give one tag a distinct `name`, rather than silently installing whichever tag was iterated first. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mxpv
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A module extension is evaluated once per build and receives the toolchain tags of every module that used it. When two modules request the same SDK version (e.g. a library and the app consuming it both pin 1.4.341.1), both tags resolve to the same repository name and install_sdk fails with a "repository already defined" error, breaking any multi-module graph that shares an SDK.
Dedupe by the resolved repository name so identical requests collapse to a single repo. When the same name is requested with different attributes -- a genuine conflict between two distinct SDKs -- fail with an actionable message telling the user to give one tag a distinct
name, rather than silently installing whichever tag was iterated first.