Skip to content

Dedupe identical vulkan_sdk toolchain tags across modules #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mxpv merged 1 commit into from
Jul 2, 2026
Merged

Dedupe identical vulkan_sdk toolchain tags across modules #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions vulkan/extensions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,28 @@ Module extension to manage Vulkan SDKs.
load("//vulkan:defs.bzl", "INSTALL_ATTRS", "install_sdk")

def _vulkan_sdk_impl(ctx):
generated = {}
for mod in ctx.modules:
for tag in mod.tags.toolchain:
name = tag.name
name = tag.name if tag.name else "vulkan_sdk_{}".format(tag.version)
kwargs = {k: getattr(tag, k) for k in INSTALL_ATTRS}
install_sdk(
name = name if name else "vulkan_sdk_{}".format(tag.version),
**kwargs
)
if name in generated:
if generated[name] != kwargs:
fail(
("Conflicting vulkan_sdk.toolchain tags resolve to the " +
"same repository '{}' but request different attributes:\n" +
" {}\n" +
"vs\n" +
" {}\n" +
"Give one of the tags a distinct `name` to install both.").format(
name,
generated[name],
kwargs,
),
)
continue
generated[name] = kwargs
install_sdk(name = name, **kwargs)

return ctx.extension_metadata(
reproducible = True,
Expand Down
Loading