feat: add landingPage support to dashboard NebariApp#3
Merged
Conversation
Expose the NebariApp CRD's landingPage field through the Helm chart so deployers can register the Ray Dashboard on the Nebari landing page without patching the rendered manifest directly. Changes: - values.yaml: add nebariapp.dashboard.landingPage block with sensible defaults (displayName, description, icon, category, priority, healthCheck) - templates/nebariapp.yaml: render spec.landingPage on the dashboard NebariApp when the block is present, including all optional sub-fields landingPage.enabled defaults to false so landing-page registration remains opt-in.
The serve NebariApp should not be exposed externally by default. Users can opt in by setting nebariapp.serve.enabled: true and providing nebariapp.hostname.
Since serve.enabled now defaults to false, the integration tests need to explicitly opt in to test the serve NebariApp path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nebariapp.dashboard.landingPageconfiguration tovalues.yamlwith sensible defaults (displayName, description, icon, category, priority, healthCheck)spec.landingPageblock on the dashboard NebariApp CR intemplates/nebariapp.yamlwhen the block is presentlandingPage.enableddefaults tofalseso registration remains opt-inThis allows deployers to register the Ray Dashboard on the Nebari landing page by setting
nebariapp.dashboard.landingPage.enabled: truein their Helm values, matching the pattern used by nebari-nebi-pack.Test plan
nebariapp.dashboard.landingPage.enabled: trueand verify the dashboard appears on the Nebari landing pagelandingPage.enabled: false(default) and verify no landing page entry is created