Skip to content

feat: add landingPage support to dashboard NebariApp #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oren-openteams merged 5 commits into from
Apr 16, 2026
Merged

feat: add landingPage support to dashboard NebariApp #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a180350
feat: add landingPage support to dashboard NebariApp template
oren-openteams Apr 14, 2026
d77720a
fix: default healthCheck to enabled
oren-openteams Apr 14, 2026
2c8ad5e
fix: use Ray Serve icon for landing page
oren-openteams Apr 14, 2026
1ba2961
Default serve endpoint to disabled
oren-openteams Apr 14, 2026
546be95
Fix CI: explicitly enable serve endpoint in integration tests
oren-openteams Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/test-integration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ jobs:
--set kuberay-operator.enabled=false \
--set nebariapp.enabled=true \
--set nebariapp.hostname=rayserve.nebari.local \
--set nebariapp.serve.enabled=true \
--set nebariapp.dashboard.enabled=true \
--set nebariapp.dashboard.hostname=ray-dashboard.nebari.local \
--set head.resources.requests.cpu=500m \
Expand Down Expand Up @@ -174,6 +175,7 @@ jobs:
--set kuberay-operator.enabled=false \
--set nebariapp.enabled=true \
--set nebariapp.hostname=rayserve.nebari.local \
--set nebariapp.serve.enabled=true \
--set nebariapp.dashboard.enabled=true \
--set nebariapp.dashboard.hostname=ray-dashboard.nebari.local \
--set nebariapp.auth.enabled=true \
Expand Down
35 changes: 35 additions & 0 deletions chart/templates/nebariapp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,40 @@ spec:
{{- toYaml .Values.nebariapp.auth.scopes | nindent 6 }}

{{- end }}
{{- with .Values.nebariapp.dashboard.landingPage }}
landingPage:
enabled: {{ .enabled | default false }}
{{- with .displayName }}
displayName: {{ . | quote }}
{{- end }}
{{- with .description }}
description: {{ . | quote }}
{{- end }}
{{- with .icon }}
icon: {{ . | quote }}
{{- end }}
{{- with .category }}
category: {{ . | quote }}
{{- end }}
{{- if kindIs "float64" .priority }}
priority: {{ .priority }}
{{- end }}
{{- with .externalUrl }}
externalUrl: {{ . | quote }}
{{- end }}
{{- with .healthCheck }}
healthCheck:
enabled: {{ .enabled | default false }}
{{- with .path }}
path: {{ . | quote }}
{{- end }}
{{- if .intervalSeconds }}
intervalSeconds: {{ .intervalSeconds }}
{{- end }}
{{- if .timeoutSeconds }}
timeoutSeconds: {{ .timeoutSeconds }}
{{- end }}
{{- end }}
{{- end }}
gateway: {{ .Values.nebariapp.gateway }}
{{- end }}
14 changes: 13 additions & 1 deletion chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,22 @@ nebariapp:
enabled: false
# hostname: rayserve.nebari.example.com # Required when serve.enabled is true
serve:
enabled: true # Set to false to keep the serve endpoint internal-only
enabled: false # Set to true and provide nebariapp.hostname to expose the serve endpoint externally
dashboard:
enabled: true
# hostname: ray-dashboard.nebari.example.com # Separate hostname for dashboard
landingPage:
enabled: false
displayName: "Ray Dashboard"
description: "Monitor and manage Ray clusters and Serve deployments"
icon: "https://raw.githubusercontent.com/ray-project/ray/master/doc/source/images/serve.svg"
category: "Data Science"
priority: 20
healthCheck:
enabled: true
path: /api/component_activities
intervalSeconds: 30
timeoutSeconds: 5
service:
name: "" # Defaults to <release>-<chart>-serve-svc (serve) or -head-svc (dashboard)
servePort: 8000
Expand Down
Loading