Conversation
fix code block add link added that SHOW commands and alter commands are not supported yet. updates to grant/revoke section in the ABAC page fix heading Update modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc add a temporal example Play-day review suggestions Play-day review suggestions Apply suggestions Play-day review suggestions Play-day review suggestions contd review fixes Re-add and fix stuff after the rebase review fixes review fix
review fixes document OR REPLACE review fixes Apply suggestions from code review Co-authored-by: Therese Magnusson <scout.therese@gmail.com>
8ed42d2 to
6f7bb8a
Compare
|
Hey @HannesSandberg, I see that you have 3 PRs that build on top of each other. Why haven't you just created a branch? I am not sure how we are supposed to review all of these. |
|
Would you like me to create a branch from dev, review these PRs, and merge them there? We can keep this branch in sync with dev, and when it's time to release ABAC, we'll merge it into dev. What do you think? |
|
Hello @renetapopova. That is because this feature is still behind a feature flag and not ready for GA. So there is one PR for every release since the Early Access Program started. The plan is to merge the entire thing when the feature is ready to be released. How to review this, I think it can be either be done after everything is implemented and documented. Then the last PR in the chain of PR would be the only one that's needs to be reviewed and I can tell you when it is time to review. The other option is to review them when they appear. Read your second message now:
I think that sounds like a good idea if the PR's to that branch also contains the preview from the neo4j-docops-agent. It is very nice to have that webpage. |
Let me see if that's possible. I'll give it a try tomorrow. |
|
Hello @lidiazuin, here is the PR where I would want some changes to
Add a new square with privileges underneath
Somewhere close to role or user management, there should be a new square with the text Does this makes sense? If you have questions, feel free to ping me here or on slack. Thanks 😃 |
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Show resolved
Hide resolved
Hunterness
left a comment
There was a problem hiding this comment.
New cluster of comments
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-roles.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-roles.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-roles.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/manage-roles.adoc
Outdated
Show resolved
Hide resolved
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Outdated
Show resolved
Hide resolved
...s/authentication-authorization/dbms-administration/dbms-auth-rule-management-privileges.adoc
Show resolved
Hide resolved
Hunterness
left a comment
There was a problem hiding this comment.
Just the leftover comment on reordering the file and a small typo left now
modules/ROOT/pages/authentication-authorization/manage-roles.adoc
Outdated
Show resolved
Hide resolved
Hunterness
left a comment
There was a problem hiding this comment.
Might be a bit odd with the combined examples that now show bits that haven't been covered yet
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/authentication-authorization/attribute-based-access-control.adoc
Outdated
Show resolved
Hide resolved
|
This PR includes documentation updates New pages: Updated pages: |
| :page-role: enterprise-edition aura-db-business-critical aura-db-dedicated | ||
|
|
||
| [[attribute-based-access-control]] | ||
| = Attribute-based access control |
There was a problem hiding this comment.
Add a introduced in version label. See this comment: #2827 (comment)
Based on top of #2879 --------- Co-authored-by: Therese Magnusson <scout.therese@gmail.com> Co-authored-by: philipwright <95368282+phil198@users.noreply.github.com> Co-authored-by: Reneta Popova <reneta.popova@neo4j.com>
Next part of documentation of ABAC, builds on top off: #2827
SHOW AUTH RULES AS COMMANDS
SHOW ROLES WITH AUTH RULES
ALTER AUTH RULE
RENAME AUTH RULE
separate sub-privileges of AUTH RULE MANAGEMENT:
CREATE AUTH RULE
SHOW AUTH RULE
RENAME AUTH RULE
DROP AUTH RULE
ALTER AUTH RULE