fix: remove {.global.} from arg in bindCallback#7
Open
wesleycoder wants to merge 2 commits intoneroist:mainfrom
Open
fix: remove {.global.} from arg in bindCallback#7wesleycoder wants to merge 2 commits intoneroist:mainfrom
wesleycoder wants to merge 2 commits intoneroist:mainfrom
Conversation
global is breaking in latest nim versions, removing it solved the problem for me. I'm a newbie in nim/webview development, but I think this shouldn't be much trouble to remove from what I tested.
Removing global comment as it is out of context by removing the global pragma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
global is breaking in latest nim versions, removing it solved the problem for me. I'm a newbie in nim/webview development, but I think this shouldn't be much trouble to remove from what I tested.