Skip to content

fix: remove {.global.} from arg in bindCallback #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wesleycoder wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove {.global.} from arg in bindCallback #7

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53feaea
remove {.global.}
wesleycoder Feb 17, 2026
3dde462
Update webview.nim
wesleycoder Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions webview.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,10 +409,7 @@ proc bindCallback*(w: Webview; name: string;
fn: proc (id: string; req: JsonNode): string): WebviewError {.discardable.} =
## Essentially a high-level version of
## `webviewBind <#webviewBind,Webview,cstring,proc(cstring,cstring,pointer),pointer>`_

# using global seems to work...
# TODO is there a better solution?
let arg {.global.} = CallBackContext(w: w, fn: fn)
let arg = CallBackContext(w: w, fn: fn)

result = w.webviewBind(name, closure, cast[pointer](arg))

Expand Down