Conversation
SourMesen
approved these changes
May 10, 2026
zeta0134
approved these changes
May 10, 2026
Collaborator
zeta0134
left a comment
zeta0134
left a comment
There was a problem hiding this comment.
This looks good and works correctly in terms of the mapper changes. The test ROM exposes a separate, unrelated issue with relative MMC5 PCM mixing. We came up with a solution for that and will address it in a separate PR. These changes are fine as is. 👍
(For testing this PR, lower the volume for MMC5 in audio settings to around 70% as a workaround.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on Heemin's changes in PR #96. Tested with his mmc5_pcmread_test ROM in that PR. There's some kind of MMC5 audio clipping problem which we'll look into in a separate PR.