NES: MMC5 DAC read mode support#96
Closed
HeeminTV wants to merge 3 commits into
Closed
Conversation
|
Are there any test ROMs for read mode PCM (and its IRQs)? Also, please remember to run the formatters - we recently enabled checks for code style consistency. |
Author
|
I had posted it in discord |
Member
|
Thanks for the change. We reworked this a bit to try to improve performance and put that into a new PR (#104). Behavior in testing is the same. With the new version, this feature costs about 1% of the framerate for MMC5 games. |
Fiskbit
added a commit
that referenced
this pull request
May 10, 2026
Based on Heemin's changes in PR #96.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.