add_packet_filters via async Gx CCR-U ADDITION + Update Bearer (#22 Increment 4) - #54
Closed
next-nf wants to merge 2 commits into
Closed
add_packet_filters via async Gx CCR-U ADDITION + Update Bearer (#22 Increment 4)#54next-nf wants to merge 2 commits into
next-nf wants to merge 2 commits into
Conversation
This was referenced Jul 22, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #53 (base
async-ue-bearer-22-inc3). Fourth increment of #22.Handles a UE
add_packet_filtersBearer Resource Command: report the new filters' content to the PCRF over a Gx CCR-Update (Packet-Filter-Operation = ADDITION), await the rule install, and emit a PTI-echoing Update Bearer Request with the expanded TFT — replacing thetrue ->rejectadd_packet_filtershit before. An add never empties a bearer, so its outcome is always Increment 3's Update path.Mostly reuse
The new code is narrow; the multi-await Update machinery is all Inc3:
6474658—smf_tft:filter_to_flow_infonow carriesPrecedence; newflow_info_to_pf_add_group/1remaps a flow-info map into a GxPacket-Filter-InformationADD group —Packet-Filter-Content(the IPFilterRule, already produced byformat_flow_description) +Precedence+Flow-Direction, dropping the UE's TFT id (not a PCRF SDF handle). Includes a real diameter encode/decode round-trip (diameter_Gx_SUITE) — the wire-shape validation the Inc2 mock path never exercised; it confirmed bare grouped-members encode cleanly (and gives the Inc2 delete group coverage by proxy).5dfba6f—pgw_s5s8: extracts Inc3's Update path into a sharedue_update_outcome/7(a byte-for-byte pure move; the Inc3 delete e2e is the guard), addsue_add_filters_proc/4(ADDITION content groups,install-only fold, unconditional Update) and theadd_packet_filtersdispatch arm. Reusesemit_ue_update_bearer/await_pfcp_modify/detect_modified_bearers/send_dedicated_bearers_update/br_ok/br_err/ccr_result/fold_ccaverbatim.Reviews & tests
{QCI,ARP}matched to the bearer so it grows rather than creates).pgw_SUITE131/131 (130 prior + 1 new add case), independently re-run; the Inc2/Inc3 delete regression stays green (the extraction is behaviour-preserving).smf_tft_SUITE26/26,diameter_Gx_SUITE8/8. Default compile green.Out of scope
replace_packet_filters(Increment 5 — needs the GxMODIFICATION-vs-delete+add semantics grounded); requested-QoS/GBR (Increment 6). An add whose PCRF response binds a new{QCI,ARP}(→ a new bearer) is out of scope — the add proc handles add-to-existing (→ Update) and acks gracefully otherwise.