Skip to content

feat: close the change-2 secret-blocking gaps - #17

Closed
nimser wants to merge 1 commit into
feat/steering-first-directionfrom
feat/change-2-secret-blocking-gap
Closed

feat: close the change-2 secret-blocking gaps#17
nimser wants to merge 1 commit into
feat/steering-first-directionfrom
feat/change-2-secret-blocking-gap

Conversation

@nimser

@nimser nimser commented Jul 5, 2026

Copy link
Copy Markdown
Owner

Closes the remaining gaps of private/openspec/changes/change-2-secret-blocking on top of the steering-first branch (stacked — retarget to main after #16's successor merges, or it will auto-retarget when the base branch is deleted).

What

  • ssh-private-key predicate rule (private-key.read-ssh-dir): blocks any non-public file under .ssh/, allowlisting config, known_hosts, authorized_keys, and *.pub/*.pubkey. Fixes a false positive: the previous regex /\.ssh/(?!.*\.pub$) blocked ~/.ssh/config and known_hosts.
  • Hardening redirect rules: < sensitive-file reads, >/>> writes, and tee to .env/.pem/.key files.
  • nonOverridable: true pack metadata (type + YAML loader passthrough), set on hardening per ADR-007. Declarative only for now — enforcement lands with the config override system (change-13).
  • Docs: regenerated docs/packs.md gallery, documented nonOverridable in docs/rule-pack-guide.md.

How

TDD: three failing tests added to src/packs/packs.test.ts first, then the minimal implementation. 240/240 tests pass, typecheck and lint clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01XLCHSd4NWR45fF5atExsbf

Add the ssh-private-key predicate (allowlisting config, known_hosts,
authorized_keys — the old regex blocked them), hardening redirect/tee
rules, and pack-level nonOverridable metadata on the hardening pack.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XLCHSd4NWR45fF5atExsbf
@coderabbitai

coderabbitai Bot commented Jul 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b7d16dc5-0b32-4767-9fc6-00ebfa77b21e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch feat/change-2-secret-blocking-gap

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Jul 5, 2026

Copy link
Copy Markdown

@nimser

nimser commented Jul 5, 2026

Copy link
Copy Markdown
Owner Author

Superseded by the standalone change-2 slice PR (change-2-secret-blocking → main); its diff is fully carried over there.

@nimser nimser closed this Jul 5, 2026
@nimser
nimser deleted the feat/change-2-secret-blocking-gap branch July 5, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant