Do not restrict workflow triggers to addon path#22
Conversation
|
Happy to merge this, I think it would be nice to have a solution that avoids checks failing on PRs like this though. |
|
OK. @nvdaes, the goal of the work in #21 was not very clear to me. Is there an add-on example of yours using the same workflow (or similar) to the one that you have pushed in #21? Seems to me that, at least that the following is not correct: The target is missing. Maybe just a dot? Additionally, is there some sens to run the |
|
@CyrilleB79 , I think that your thoughts are right. I searched a lot of documentation for that work, as much as possible. Of course, now the version of actions may be updated. About addonTemplate, I agree with you. We can restrict this if repo is nvaccess/addonTemplate |
Various CI fixes and improvements:
Do not try to build / make release if the workflow is run from this add-on template repo, since it fails and the template is not meant to be used as a release. Fixes: Do not restrict workflow triggers to addon path #22 (comment).
Modernized uv usage with "uv sync", fixing the failure on previously used "uv pip install". Discussed in Do not restrict workflow triggers to addon path #22 (comment).
Use uv for each command using Python so that the correct environment is used
Added .egg-info to .git-ignore
Updated readme
Issue
In #21, a restriction has been added to workflow triggers so that the workflow runs only if files in the addon subfolder are modified.
Though as discussed in #21 (comment), modifying files outside the
addonfolder may have an impact on the generated.addonfile:readme.md,style.css)buildVars.pycontrols the bundled manifest file,sconstructmodification can have any effect, including on what is in the bundle, etc.Solution
Removed the path restriction.
Note
Alternative solution was discussed, e.g. exclude some folders from the trigger rather than including only the "addon" folder. Though, it seems to me that making any hypothesis on which file / folder impacts the add-on bundle's content is quite fragile.