Jg/cip 0105 externally implemented governance locks - #2
Open
jonored wants to merge 36 commits into
Open
Conversation
…ed-governance-locks' into jg/cip-0105-externally-implemented-governance-locks
Dpak/cip 105 v2 vesting
…evelopment cycles by allowing the LSP to work cross-package when working on code.
Fix some issues related to PR comments for VestingLock
* Remove scan transactions endpoint Already deprecated, we removed /activities already, metrics show basically no usage (< 1 request per day) and next release is 0.7.0 so perfect time for removing a deprecated endpoint. [ci] Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> * fix rate limits [ci] Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> --------- Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
…ev cycles (canton-network#6523) --------- Signed-off-by: Cale Gibbard <cale.gibbard@obsidian.systems>
--------- Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
fixes canton-network#6553 [ci] --------- Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org> Co-authored-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Prior to v1.11.1, sbt had a memory leak (sbt/sbt#8142) in its `update` task that caused memory usage to grow linearly with the number of `update`s performed. This affects regular development as `update` is called as part of the `compile` task dependency graph. After upgrading to a version that includes the fix (coursier/sbt-coursier#563, coursier/sbt-coursier#564), I've found development with sbt, especially with long-running sbt shell sessions, to be a more pleasant experience; there's less sluggishness and a lot fewer warnings that say "X seconds of the last 10 seconds were spent in garbage collection." Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
* Specify set of valid response content types. Fixes canton-network#6483. This updates `HttpClient.createHttpFn` to consider a response invalid if its content type is not `application/json`, `application/octet-stream`, or `text/plain`. This results in `httpClientWithErrors` calling `getApiErrorFromResponse`, which produces an `HttpCommandException` and includes the raw response body in its error message. These three content types are the only ones used across all the OpenAPI specs in the repo. `text-plain` is used by [`devNetOnboardValidatorPrepare`](https://github.com/canton-network/splice/blob/main/apps/sv/src/main/openapi/sv-internal.yaml#L506-L508), and `application/octet-stream` is used by [`bulkStorageDownload`](https://github.com/canton-network/splice/blob/main/apps/scan/src/main/openapi/scan-stream-server.yaml#L46-L50). Signed-off-by: Matt Dziuban <mrdziuban@gmail.com> * Ensure responses with `ContentTypes.NoContentType` are considered valid. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com> * Run scalafmt. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com> --------- Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
Address some CIP-0105 PR comments
…ing up development cycles by allowing the LSP to work cross-package when working on code." This reverts commit 15dfa70.
…y-implemented-governance-locks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More of a directional sketch than a proper PR: implementation of basic CIP-0105 governance locking and unlock to a vesting state on top of V2 allocations.
Not intended to cover most of the scenario; only for technical approach discussion.
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines