Jg/cip 0105 externally implemented governance locks

.github/workflows/build.deployment_test.yml

@@ -25,7 +25,7 @@ jobs:
       - name: Setup
         uses: ./.github/actions/tests/common_test_setup
         with:
-          cache_version: 8
+          cache_version: 9
           test_name: deployment_test
           with_sbt: false
 

.github/workflows/build.docs.yml

@@ -25,7 +25,7 @@ jobs:
         id: setup
         uses: ./.github/actions/tests/common_test_setup
         with:
-          cache_version: 8
+          cache_version: 9
           test_name: docs
           save_nix_cache: true
           save_nix_cache_to_gcp: ${{ github.ref == 'refs/heads/main' && github.event_name == 'push' }}
@@ -48,7 +48,7 @@ jobs:
       - name: Post-SBT job
         uses: ./.github/actions/sbt/post_sbt
         with:
-          cache_version: 8
+          cache_version: 9
           setup_sbt_cache_hits: ${{ steps.setup.outputs.sbt_cache_hits }}
 
       - name: Report Failures on Slack & Github

.github/workflows/build.scala_test.yml

@@ -137,7 +137,7 @@ jobs:
       - name: Run Tests
         uses: ./.github/actions/tests/scala_test
         with:
-          cache_version: 8
+          cache_version: 9
           with_canton: ${{ inputs.with_canton }}
           start_canton_options: ${{ inputs.start_canton_options }}
           test_suite_name: ${{ inputs.test_name }}

.github/workflows/build.scala_test_for_compose.yml

@@ -104,7 +104,7 @@ jobs:
       - name: Run Tests
         uses: ./.github/actions/tests/scala_test
         with:
-          cache_version: 8
+          cache_version: 9
           start_canton_options: ${{ inputs.start_canton_options }}
           test_suite_name: ${{ inputs.test_name }}
           test_names: ${{ needs.split_tests.outputs.test_names }}

.github/workflows/build.scala_test_with_cometbft.yml

@@ -120,7 +120,7 @@ jobs:
       - name: Run Tests
         uses: ./.github/actions/tests/scala_test
         with:
-          cache_version: 8
+          cache_version: 9
           start_canton_options: -F -w
           test_suite_name: ${{ inputs.test_name }}
           test_names: ${{ needs.split_tests.outputs.test_names }}

.github/workflows/build.static_tests.yml

@@ -31,7 +31,7 @@ jobs:
       - name: Setup Nix
         uses: ./.github/actions/tests/common_test_setup
         with:
-          cache_version: 8
+          cache_version: 9
           test_name: canton_consistency
           target: 'static_tests'
 
@@ -84,7 +84,7 @@ jobs:
         id: setup
         uses: ./.github/actions/tests/common_test_setup
         with:
-          cache_version: 8
+          cache_version: 9
           test_name: static_tests
           target: 'static_tests'
 

.github/workflows/build.ts_cli_tests.yml

@@ -41,7 +41,7 @@ jobs:
         if: steps.skip.outputs.skip != 'true'
         uses: ./.github/actions/tests/common_test_setup
         with:
-          cache_version: 8
+          cache_version: 9
           test_name: ts_cli
 
       - name: Run Token Standard CLI tests

.github/workflows/build.ui_tests.yml

@@ -41,7 +41,7 @@ jobs:
         if: steps.skip.outputs.skip != 'true'
         uses: ./.github/actions/tests/common_test_setup
         with:
-          cache_version: 8
+          cache_version: 9
           test_name: ui_tests
 
       - name: Run UI tests
@@ -62,7 +62,7 @@ jobs:
         if: steps.skip.outputs.skip != 'true'
         uses: ./.github/actions/sbt/post_sbt
         with:
-          cache_version: 8
+          cache_version: 9
           setup_sbt_cache_hits: ${{ steps.setup.outputs.sbt_cache_hits }}
 
       - name: Upload logs

.github/workflows/bump_gha_runner_version.yml

@@ -27,7 +27,7 @@ jobs:
       - name: Set up Nix (Self hosted)
         uses: ./.github/actions/nix/setup_nix
         with:
-          cache_version: 8
+          cache_version: 9
           target: default
 
       - name: Check for the latest version and create a PR to splice

.github/workflows/performance_tests.yml

@@ -34,7 +34,7 @@ jobs:
         id: setup
         uses: ./.github/actions/tests/common_test_setup
         with:
-          cache_version: 8
+          cache_version: 9
           test_name: ingestion_performance_tests
 
       # Authenticate to GCP for read access to GCS
@@ -137,7 +137,7 @@ jobs:
         id: setup
         uses: ./.github/actions/tests/common_test_setup
         with:
-          cache_version: 8
+          cache_version: 9
           test_name: read_performance_tests
 
       # Authenticate to GCP for read access to GCS

.github/workflows/pr_check_github_scripts.yml

@@ -15,7 +15,7 @@ jobs:
     - name: Set up Nix
       uses: ./.github/actions/nix/setup_nix
       with:
-        cache_version: 8
+        cache_version: 9
     - name: Check github scripts
       uses: ./.github/actions/nix/run_bash_command_in_nix
       with:

.gitignore

@@ -22,6 +22,8 @@ _build/
 **/metals.sbt
 **/.scala-build/*
 
+daml/daml-ide-mono/daml/
+daml/daml-ide-mono/.vscode/
 .vscode/*
 !.vscode/settings.json
 # Make sure test files are checkedin

apps/app/src/main/resources/application.conf

@@ -2,7 +2,8 @@
 pekko.http.server.request-timeout = 38 seconds
 pekko.http.server.parsing.error-handler="org.lfdecentralizedtrust.splice.http.PekkoHttpParsingErrorHandler$"
 pekko.http.server.parsing.ignore-illegal-header-for =
-  [ "authorization"
+  [ "accept-language"
+    "authorization"
     "cookie"
     "origin"
     "proxy-authorization"

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/console/ScanAppReference.scala

@@ -368,20 +368,6 @@ abstract class ScanAppReference(
       httpCommand(HttpScanAppClient.GetRewardAccountingBatch(roundNumber, batchHash))
     }
 
-  import org.lfdecentralizedtrust.splice.http.v0.definitions.TransactionHistoryResponseItem
-  import org.lfdecentralizedtrust.splice.http.v0.definitions.TransactionHistoryRequest.SortOrder
-
-  def listTransactions(
-      pageEndEventId: Option[String],
-      sortOrder: SortOrder,
-      pageSize: Int,
-  ): Seq[TransactionHistoryResponseItem] =
-    consoleEnvironment.run {
-      httpCommand(
-        HttpScanAppClient.ListTransactions(pageEndEventId, sortOrder, pageSize)
-      )
-    }
-
   def getAcsSnapshot(party: PartyId, recordTime: Option[Instant]): ByteString =
     consoleEnvironment.run {
       httpCommand(

apps/app/src/main/scala/org/lfdecentralizedtrust/splice/console/SvAppReference.scala

@@ -134,7 +134,7 @@ abstract class SvAppReference(
   @Help.Summary("Cancel a running logical synchronizer upgrade by removing its LSU announcement")
   def cancelLogicalSynchronizerUpgrade(): Unit =
     consoleEnvironment.run {
-      httpCommand(HttpSvAdminAppClient.CancelLogicalSynchronizerUpgrade())
+      httpCommand(HttpSvOperatorAppClient.CancelLogicalSynchronizerUpgrade())
     }
 
   @Help.Summary("Get identities of all domain node components")

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/EnvironmentDefinition.scala

@@ -504,6 +504,13 @@ case class EnvironmentDefinition(
       )
   }
 
+  def withTransferCommandSupport: EnvironmentDefinition =
+    this.addConfigTransform((_, conf) =>
+      ConfigTransforms.updateAllValidatorAppConfigs_(
+        _.copy(enableDeprecatedTransferCommandSupport = true)
+      )(conf)
+    )
+
   def clearConfigTransforms(): EnvironmentDefinition =
     copy(configTransformsWithContext = _ => Seq())
 

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/ExternalPartySetupProposalIntegrationTest.scala

@@ -103,6 +103,7 @@ class ExternalPartySetupProposalIntegrationTest
             NonNegativeFiniteDuration.ofMillis(500)
           )(config),
       )
+      .withTransferCommandSupport
 
   }
 

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/ExternallySignedTxTest.scala

@@ -21,7 +21,7 @@ trait ExternallySignedTxTest
 
   override def environmentDefinition: SpliceEnvironmentDefinition = {
     EnvironmentDefinition.simpleTopology1Sv(this.getClass.getSimpleName)
-  }
+  }.withTransferCommandSupport
 
   def prepareAndSubmitTransfer(keyName: String, sender: PartyId, receiver: PartyId)(implicit
       env: SpliceTestConsoleEnvironment

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/ExternallySignedTxsTimeBasedIntegrationTest.scala

@@ -26,6 +26,7 @@ class ExternallySignedTxsTimeBasedIntegrationTest
   override def environmentDefinition: SpliceEnvironmentDefinition =
     EnvironmentDefinition
       .simpleTopology1SvWithSimTime(this.getClass.getSimpleName)
+      .withTransferCommandSupport
 
   "Externally signed transactions can tolerate a preparation/submission skew larger than ledgerTimeRecordTimeTolerance" in {
     implicit env =>

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/LsuIntegrationTest.scala

@@ -29,7 +29,6 @@ import org.lfdecentralizedtrust.splice.environment.{
   SequencerAdminConnection,
 }
 import org.lfdecentralizedtrust.splice.http.v0.definitions
-import org.lfdecentralizedtrust.splice.http.v0.definitions.TransactionHistoryRequest
 import org.lfdecentralizedtrust.splice.integration.EnvironmentDefinition
 import org.lfdecentralizedtrust.splice.integration.tests.SpliceTests.{
   IntegrationTest,
@@ -204,6 +203,7 @@ class LsuIntegrationTest
       .withSvBftSequencerConnectionDisabled()
       .withAmuletPrice(walletAmuletPrice)
       .withManualStart
+      .withTransferCommandSupport
 
   override def walletAmuletPrice: java.math.BigDecimal = SpliceUtil.damlDecimal(1.0)
 
@@ -373,14 +373,13 @@ class LsuIntegrationTest
       initDso(includeLocal = false)
       startAllSync(aliceValidatorBackend, splitwellValidatorBackend)
       actAndCheck("Create some transaction history", sv1WalletClient.tap(1337))(
-        "Scan transaction history is recorded and wallet balance is updated",
+        "Wallet balance is updated",
         _ => {
           // buffer to account for domain fee payments
           assertInRange(
             sv1WalletClient.balance().unlockedQty,
             (walletUsdToAmulet(1000), walletUsdToAmulet(2000)),
           )
-          countTapsFromScan(sv1ScanBackend, walletUsdToAmulet(1337)) shouldBe 1
         },
       )
 
@@ -962,16 +961,6 @@ class LsuIntegrationTest
       retryProvider,
     )
 
-  private def countTapsFromScan(scan: ScanAppBackendReference, tapAmount: BigDecimal) = {
-    listTransactionsFromScan(scan).count(
-      _.tap.map(a => BigDecimal(a.amuletAmount)).contains(tapAmount)
-    )
-  }
-
-  private def listTransactionsFromScan(scan: ScanAppBackendReference) = {
-    scan.listTransactions(None, TransactionHistoryRequest.SortOrder.Asc, 100)
-  }
-
   private def getSequencerUrlsConfiguredForTheSync(
       participantConnection: ParticipantClientReference,
       synchronizerAlias: SynchronizerAlias,

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/MultiHostValidatorOperatorIntegrationTest.scala

@@ -1,11 +1,9 @@
 package org.lfdecentralizedtrust.splice.integration.tests
 
 import com.digitalasset.canton.topology.transaction.*
-import org.lfdecentralizedtrust.splice.http.v0.definitions.TransactionHistoryRequest
 import org.lfdecentralizedtrust.splice.integration.EnvironmentDefinition
 import org.lfdecentralizedtrust.splice.integration.tests.SpliceTests.IntegrationTest
 import org.lfdecentralizedtrust.splice.util.WalletTestUtil
-import org.lfdecentralizedtrust.splice.store.Limit
 
 import java.nio.file.Files
 import java.util.UUID
@@ -212,19 +210,8 @@ class MultiHostValidatorOperatorIntegrationTest extends IntegrationTest with Wal
     )(
       "The send succeeds despite alice's validator being disconnected and stopped",
       _ => {
-        // Fees eat up quite a bit
         splitwellWalletClient.balance().unlockedQty should be(60)
-        // Alice's wallet is stopped, so we confirm the transaction via scan
-        sv1ScanBackend
-          .listTransactions(
-            None,
-            TransactionHistoryRequest.SortOrder.Desc,
-            Limit.DefaultMaxPageSize,
-          )
-          .flatMap(_.transfer)
-          .filter(tf =>
-            tf.description == transferDescription
-          ) should not be empty withClue "transfers splitwell to alice"
+        // don't check on alice's wallet as it's stopped. the transaction going through on splitwell is enough signal.
       },
     )
   }

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/RecoverExternalPartyIntegrationTest.scala

@@ -31,7 +31,7 @@ class RecoverExternalPartyIntegrationTest
     with WalletTestUtil {
 
   override def environmentDefinition: EnvironmentDefinition =
-    EnvironmentDefinition.simpleTopology1Sv(this.getClass.getSimpleName)
+    EnvironmentDefinition.simpleTopology1Sv(this.getClass.getSimpleName).withTransferCommandSupport
 
   override protected lazy val sanityChecksIgnoredRootCreates = Seq(
     ValidatorRewardCoupon.TEMPLATE_ID_WITH_PACKAGE_ID

apps/app/src/test/scala/org/lfdecentralizedtrust/splice/integration/tests/RollForwardLsuIntegrationTest.scala

@@ -18,7 +18,6 @@ import org.lfdecentralizedtrust.splice.environment.{
   MediatorAdminConnection,
   SequencerAdminConnection,
 }
-import org.lfdecentralizedtrust.splice.http.v0.definitions.TransactionHistoryRequest
 import monocle.macros.syntax.lens.*
 import org.lfdecentralizedtrust.splice.integration.EnvironmentDefinition
 import org.lfdecentralizedtrust.splice.integration.tests.SpliceTests.IntegrationTest
@@ -164,14 +163,13 @@ class RollForwardLsuIntegrationTest
     startAllSync(allNodes*)
 
     actAndCheck("Create some transaction history", sv1WalletClient.tap(1337))(
-      "Scan transaction history is recorded and wallet balance is updated",
+      "Wallet balance is updated",
       _ => {
         // buffer to account for domain fee payments
         assertInRange(
           sv1WalletClient.balance().unlockedQty,
           (walletUsdToAmulet(1000), walletUsdToAmulet(2000)),
         )
-        countTapsFromScan(sv1ScanBackend, walletUsdToAmulet(1337)) shouldBe 1
       },
     )
 
@@ -429,16 +427,6 @@ class RollForwardLsuIntegrationTest
       retryProvider,
     )
 
-  private def countTapsFromScan(scan: ScanAppBackendReference, tapAmount: BigDecimal) = {
-    listTransactionsFromScan(scan).count(
-      _.tap.map(a => BigDecimal(a.amuletAmount)).contains(tapAmount)
-    )
-  }
-
-  private def listTransactionsFromScan(scan: ScanAppBackendReference) = {
-    scan.listTransactions(None, TransactionHistoryRequest.SortOrder.Asc, 100)
-  }
-
   private def getSequencerUrlSet(
       participantConnection: ParticipantClientReference,
       synchronizerAlias: SynchronizerAlias,