Remove reference library module - #65
Closed
FikriMilano wants to merge 10 commits into
Closed
Conversation
Member
Author
|
Blocked: |
FikriMilano
commented
Jul 15, 2026
FikriMilano
left a comment
FikriMilano
left a comment
Member
Author
There was a problem hiding this comment.
@ellykits please add some pointers about the README.md
ellykits
requested changes
Jul 15, 2026
ellykits
left a comment
ellykits
left a comment
Contributor
There was a problem hiding this comment.
On the documentation for the reference app, please add these content (unordered):
- How to get started with this GitHub template
- How to customize and personalize the code, like package
- The OHS foundation libraries that are bandled with the reference app (changing application name, icon etc)
- How to run the reference app for those who just want to see OHS in action
- Developer setup for KMP multiplatform
- How to use the OHS player reference library for users with existing implementation who cannot afford to tweak this template for their use case
- Mention the supported platforms and how they can be deployed via Git CI
Please add any relevant info that I may have left out. You can order the items above in the README. You don't have to get into a lot of details.
2 tasks
LZRS
added a commit
to LZRS/ohs-player-reference-client-app
that referenced
this pull request
Aug 10, 2026
Recreates PR ohs-foundation#65 on top of current main. PR ohs-foundation#65's own diff (module rename, local library removal, dev.ohs.player.library -> client import rename) applies unchanged where main hasn't moved; two gaps that would have broken the build regardless of conflicts are also fixed: - ig-codegen still emitted dev.ohs.player.library.* references (config/registry) that no longer exist once the library module is removed - Compose's generated resources package name shifts with rootProject.name/module rename (ohsplayerreferenceclientapp.ohs_player_reference_app.generated.resources -> player_reference.reference_app.generated.resources) release.yml and iosApp project.pbxproj carry PR ohs-foundation#65's already-correct :ohs-player-reference-app: -> :reference-app: task renames, since main never touched those files. Verified: :reference-app:compileKotlinJvm, :reference-app:jvmTest, :reference-app:lintDebug, spotlessCheck all pass. Co-authored-by: Fikri Milano <fikrimilano1@gmail.com>
Contributor
|
Closing. This should be addressed in a separate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64 #56
Remove all artifacts of the client library
Replaces the direct module call with actual dependency Use the remote reference-library after available on Maven Central #56
Rework the readme
Rename rootProject.name to
player-referenceUpdate the imports from
dev.ohs.player.library.*todev.ohs.player.client.*All CI build checks pass e.g. Tests
Appropriate changes to documentation are included in the PR