Remove reference library module, rename module to reference-app - #68
Merged
Conversation
This was
linked to
issues
Aug 10, 2026
Recreates PR ohs-foundation#65 on top of current main. PR ohs-foundation#65's own diff (module rename, local library removal, dev.ohs.player.library -> client import rename) applies unchanged where main hasn't moved; two gaps that would have broken the build regardless of conflicts are also fixed: - ig-codegen still emitted dev.ohs.player.library.* references (config/registry) that no longer exist once the library module is removed - Compose's generated resources package name shifts with rootProject.name/module rename (ohsplayerreferenceclientapp.ohs_player_reference_app.generated.resources -> player_reference.reference_app.generated.resources) release.yml and iosApp project.pbxproj carry PR ohs-foundation#65's already-correct :ohs-player-reference-app: -> :reference-app: task renames, since main never touched those files. Verified: :reference-app:compileKotlinJvm, :reference-app:jvmTest, :reference-app:lintDebug, spotlessCheck all pass. Co-authored-by: Fikri Milano <fikrimilano1@gmail.com>
LZRS
force-pushed
the
resolve-pr65-on-main
branch
from
August 10, 2026 07:29
2e21993 to
1a6aa3a
Compare
LZRS
marked this pull request as ready for review
August 10, 2026 07:29
ellykits
approved these changes
Aug 10, 2026
Contributor
|
Please look at the documentation on the README. I've approved. Most of the work here was mechanical change to the new library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreates PR #65 on top of current main.
Also updates
ig-codegenthat still referenced the olddev.ohs.player.library.*player_reference.reference_app.generated.resources