Skip to content

Add slightly more strict test verifiction#7595

Merged
jkwatson merged 1 commit into
open-telemetry:mainfrom
trask:withStrictTypeChecking
Aug 19, 2025
Merged

Add slightly more strict test verifiction#7595
jkwatson merged 1 commit into
open-telemetry:mainfrom
trask:withStrictTypeChecking

Conversation

@trask

@trask trask commented Aug 19, 2025

Copy link
Copy Markdown
Member

I started to fix #7568, but found this will help with adding the test for it, and is probably a good change independently, so sending it separately

assertThat(copy.unwrap())
.extracting("builder")
.usingRecursiveComparison()
.withStrictTypeChecking()

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trask trask marked this pull request as ready for review August 19, 2025 18:15
@trask trask requested a review from a team as a code owner August 19, 2025 18:15
@codecov

codecov Bot commented Aug 19, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.00%. Comparing base (f984d20) to head (63480e8).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7595      +/-   ##
============================================
- Coverage     90.01%   90.00%   -0.01%     
  Complexity     7080     7080              
============================================
  Files           803      803              
  Lines         21417    21417              
  Branches       2086     2086              
============================================
- Hits          19278    19276       -2     
- Misses         1477     1478       +1     
- Partials        662      663       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jkwatson jkwatson merged commit cbc1183 into open-telemetry:main Aug 19, 2025
29 checks passed
@trask trask deleted the withStrictTypeChecking branch October 20, 2025 17:27
the-clam pushed a commit to the-clam/opentelemetry-java that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HttpExporterBuilder.copy() loses original ClassLoader breaking Java agent

2 participants