Skip to content

Add slightly more strict test verifiction #7595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jkwatson merged 1 commit into from
Aug 19, 2025
Merged

Add slightly more strict test verifiction #7595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...va/io/opentelemetry/exporter/otlp/testing/internal/AbstractGrpcTelemetryExporterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -988,6 +988,7 @@ void toBuilderEquality()
assertThat(copy.unwrap())
.extracting("builder")
.usingRecursiveComparison()
.withStrictTypeChecking()

@trask trask Aug 19, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here's the Javadoc for this method: https://javadoc.io/static/org.assertj/assertj-core/3.24.2/org/assertj/core/api/RecursiveComparisonAssert.html#withStrictTypeChecking()

.ignoringFields("tlsConfigHelper")
.isEqualTo(builderField.get(unwrapped));
} finally {
Expand All @@ -1000,6 +1001,7 @@ void toBuilderEquality()
assertThat(copy.unwrap())
.extracting("builder")
.usingRecursiveComparison()
.withStrictTypeChecking()
.ignoringFields("tlsConfigHelper")
.isNotEqualTo(builderField.get(unwrapped));
} finally {
Expand Down
2 changes: 2 additions & 0 deletions ...va/io/opentelemetry/exporter/otlp/testing/internal/AbstractHttpTelemetryExporterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -850,6 +850,7 @@ void toBuilderEquality()
assertThat(copy.unwrap())
.extracting("builder")
.usingRecursiveComparison()
.withStrictTypeChecking()
.ignoringFields("tlsConfigHelper")
.isEqualTo(builderField.get(unwrapped));
} finally {
Expand All @@ -862,6 +863,7 @@ void toBuilderEquality()
assertThat(copy.unwrap())
.extracting("builder")
.usingRecursiveComparison()
.withStrictTypeChecking()
.ignoringFields("tlsConfigHelper")
.isNotEqualTo(builderField.get(unwrapped));
} finally {
Expand Down
5 changes: 4 additions & 1 deletion sdk/logs/src/test/java/io/opentelemetry/sdk/logs/LogLimitsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@ void updateLogLimits_All() {
// Preserves values
LogLimits logLimitsDupe = logLimits.toBuilder().build();
// Use reflective comparison to catch when new fields are added.
assertThat(logLimitsDupe).usingRecursiveComparison().isEqualTo(logLimits);
assertThat(logLimitsDupe)
.usingRecursiveComparison()
.withStrictTypeChecking()
.isEqualTo(logLimits);
}

@Test
Expand Down
2 changes: 2 additions & 0 deletions sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/internal/view/ViewRegistryTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,7 @@ void findViews_ApplyAdvice() {
assertThat(view)
.as("is the same as the default view, except the attributes processor")
.usingRecursiveComparison()
.withStrictTypeChecking()
.ignoringFields("viewAttributesProcessor")
.isEqualTo(DEFAULT_REGISTERED_VIEW);
assertThat(view)
Expand Down Expand Up @@ -520,6 +521,7 @@ void findViews_ApplyAdvice() {
assertThat(view)
.as("is the same as the default view, except the attributes processor")
.usingRecursiveComparison()
.withStrictTypeChecking()
.ignoringFields("viewAttributesProcessor")
.isEqualTo(DEFAULT_REGISTERED_VIEW);
assertThat(view)
Expand Down
5 changes: 4 additions & 1 deletion sdk/trace/src/test/java/io/opentelemetry/sdk/trace/config/SpanLimitsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,10 @@ void updateSpanLimits_All() {
// Preserves values
SpanLimits spanLimitsDupe = spanLimits.toBuilder().build();
// Use reflective comparison to catch when new fields are added.
assertThat(spanLimitsDupe).usingRecursiveComparison().isEqualTo(spanLimits);
assertThat(spanLimitsDupe)
.usingRecursiveComparison()
.withStrictTypeChecking()
.isEqualTo(spanLimits);
}

@Test
Expand Down
Loading