Fix dead benchmarks link in documentation#4238
Open
rohansood10 wants to merge 1 commit intoopen-telemetry:mainfrom
Open
Fix dead benchmarks link in documentation#4238rohansood10 wants to merge 1 commit intoopen-telemetry:mainfrom
rohansood10 wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
The benchmarks page on GitHub Pages no longer exists. Update the documentation to point users to the in-repo benchmark directories instead. Fixes open-telemetry#4163 Signed-off-by: rohansood10 <rohansood10@users.noreply.github.com>
| Performance benchmarks for individual packages can be found within each package's directory | ||
| (e.g., ``propagator/opentelemetry-propagator-aws-xray/benchmarks/``). | ||
|
|
||
| To run benchmarks locally, install the package with its benchmark dependencies and use ``pytest --benchmark-only``. |
Contributor
There was a problem hiding this comment.
Thanks for catching this!
To reduce duplication, I suggest pointing to ## Benchmarks in Contributing.md
Results are also available now at https://opentelemetry.io/docs/languages/python/benchmarks/
tammy-baylis-swi
moved this to Reviewed PRs that need fixes
in @xrmx's Python PR digest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4163
The benchmarks page at
https://open-telemetry.github.io/opentelemetry-python-contrib/benchmarks/index.htmlreturns a 404. The entire GitHub Pages site appears to be down.This updates
docs/performance/benchmarks.rstto point users to the in-repo benchmark directories instead of the dead external link.