Skip to content

Comments

[google-genai] Test instrumentation on google-genai v1.63.0#4247

Closed
Rima-ag wants to merge 7 commits intoopen-telemetry:mainfrom
Rima-ag:google-genai-version-63
Closed

[google-genai] Test instrumentation on google-genai v1.63.0#4247
Rima-ag wants to merge 7 commits intoopen-telemetry:mainfrom
Rima-ag:google-genai-version-63

Conversation

@Rima-ag
Copy link

@Rima-ag Rima-ag commented Feb 21, 2026

Description

Bumps the latest google-genai package version to 1.63.0.
That package version requires python >=3.10 and google-auth==2.38.0.

I initially wanted to update it to 1.64.0, but tests are failing. I fixed one issue, but these 2 tests are hanging and I'm still trying to figure out why:

test_e2e.py::test_streaming[logcontent-gemini-2.5-flash-vertexaiapi-async-default]
test_e2e.py::test_streaming[excludecontent-gemini-2.5-flash-vertexaiapi-async-default]

#4240

Type of change

  • Tests
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

The following tests passed:

tox -e \                                                                                     
py39-test-instrumentation-google-genai-oldest,\
py39-test-instrumentation-google-genai-latest,\
py310-test-instrumentation-google-genai-oldest,\
py310-test-instrumentation-google-genai-latest,\
py311-test-instrumentation-google-genai-oldest,\
py311-test-instrumentation-google-genai-latest,\
py312-test-instrumentation-google-genai-oldest,\
py312-test-instrumentation-google-genai-latest,\
py313-test-instrumentation-google-genai-oldest,\
py313-test-instrumentation-google-genai-latest,\
py314-test-instrumentation-google-genai-oldest,\
py314-test-instrumentation-google-genai-latest

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Rima-ag Rima-ag marked this pull request as ready for review February 21, 2026 21:28
@Rima-ag Rima-ag requested a review from a team as a code owner February 21, 2026 21:28
@tammy-baylis-swi tammy-baylis-swi moved this from Approved PRs to Approved PRs that need fixes in @xrmx's Python PR digest Feb 23, 2026
@aabmass aabmass added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 23, 2026
@aabmass
Copy link
Member

aabmass commented Feb 23, 2026

Can you run tox -e generate to fix the table? https://github.com/open-telemetry/opentelemetry-python-contrib/blob/main/CONTRIBUTING.md#development

# limitations under the License.

_instruments = ("google-genai >= 1.0.0",)
_instruments = ("google-genai >= 1.0.0, <= 1.63.0",)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also should update

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh the lower limit is not the same in the two files, should I update the one in package.py to 1.32.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's still worth merging this PR now that I actually have a fix for 1.64.0 #4253, so I fixed the lower bound there.

@Rima-ag Rima-ag closed this Feb 24, 2026
@github-project-automation github-project-automation bot moved this from Approved PRs that need fixes to Done in @xrmx's Python PR digest Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants