[google-genai] Test instrumentation on google-genai v1.63.0#4247
Closed
Rima-ag wants to merge 7 commits intoopen-telemetry:mainfrom
Closed
[google-genai] Test instrumentation on google-genai v1.63.0#4247Rima-ag wants to merge 7 commits intoopen-telemetry:mainfrom
Rima-ag wants to merge 7 commits intoopen-telemetry:mainfrom
Conversation
aabmass
approved these changes
Feb 23, 2026
...metry-instrumentation-google-genai/src/opentelemetry/instrumentation/google_genai/package.py
Show resolved
Hide resolved
instrumentation-genai/opentelemetry-instrumentation-google-genai/tests/requirements.latest.txt
Outdated
Show resolved
Hide resolved
Member
|
Can you run |
aabmass
approved these changes
Feb 23, 2026
| # limitations under the License. | ||
|
|
||
| _instruments = ("google-genai >= 1.0.0",) | ||
| _instruments = ("google-genai >= 1.0.0, <= 1.63.0",) |
Member
There was a problem hiding this comment.
I think you also should update
Author
There was a problem hiding this comment.
Oh the lower limit is not the same in the two files, should I update the one in package.py to 1.32.0?
Author
There was a problem hiding this comment.
I'm not sure if it's still worth merging this PR now that I actually have a fix for 1.64.0 #4253, so I fixed the lower bound there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bumps the latest google-genai package version to 1.63.0.
That package version requires python >=3.10 and google-auth==2.38.0.
I initially wanted to update it to 1.64.0, but tests are failing. I fixed one issue, but these 2 tests are hanging and I'm still trying to figure out why:
#4240
Type of change
How Has This Been Tested?
The following tests passed:
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.