-
Notifications
You must be signed in to change notification settings - Fork 877
[google-genai] Test instrumentation on google-genai v1.63.0 #4247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d842c34
e3d4fbe
f48555f
72a9792
1549e81
65b9422
6f2789d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -12,4 +12,4 @@ | |||||
| # See the License for the specific language governing permissions and | ||||||
| # limitations under the License. | ||||||
|
|
||||||
| _instruments = ("google-genai >= 1.0.0",) | ||||||
| _instruments = ("google-genai >= 1.0.0, <= 1.63.0",) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you also should update
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done!
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Oh the lower limit is not the same in the two files, should I update the one in package.py to 1.32.0?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. SGTM
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure if it's still worth merging this PR now that I actually have a fix for 1.64.0 #4253, so I fixed the lower bound there. |
||||||
Uh oh!
There was an error while loading. Please reload this page.