Skip to content

Update profiles specification README.md and pprof.md#4932

Merged
tigrannajaryan merged 14 commits into
open-telemetry:mainfrom
christos68k:ck/profiles
May 27, 2026
Merged

Update profiles specification README.md and pprof.md#4932
tigrannajaryan merged 14 commits into
open-telemetry:mainfrom
christos68k:ck/profiles

Conversation

@christos68k

@christos68k christos68k commented Mar 11, 2026

Copy link
Copy Markdown
Member

Changes

This update takes into account the recent introduction of a profiles signal concepts page, removes duplicate information and adds more relevant documentation.

There is a follow-up PR here that adds the current data format page.

CC: @theletterf @open-telemetry/profiling-maintainers @open-telemetry/profiling-approvers

  • Related issues: #7874
  • CHANGELOG.md file updated for non-trivial changes
    • For trivial changes, include [chore] in the PR title to skip the changelog check

This update take into account the recent introduction of a profiles
signal concepts page, removes duplicate information and adds more
relevant documentation.
@christos68k christos68k requested review from a team as code owners March 11, 2026 09:10
Comment thread specification/profiles/README.md
Comment thread specification/profiles/README.md Outdated
@christos68k christos68k added the spec:profiling Related to the specification/profiling directory label Mar 11, 2026
Comment thread specification/profiles/pprof.md Outdated
Comment thread specification/profiles/README.md Outdated
Comment thread specification/profiles/README.md

@felixge felixge left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, but LGTM overall.

Comment thread specification/profiles/README.md Outdated
Comment thread specification/profiles/README.md Outdated
Comment thread specification/profiles/README.md Outdated
Comment thread specification/profiles/README.md Outdated
Comment thread specification/profiles/README.md Outdated
christos68k and others added 3 commits March 11, 2026 13:06
Co-authored-by: Felix Geisendörfer <felix@felixge.de>
Co-authored-by: Felix Geisendörfer <felix@felixge.de>
Co-authored-by: Felix Geisendörfer <felix@felixge.de>
Comment thread specification/profiles/pprof.md
@tigrannajaryan tigrannajaryan self-assigned this Mar 18, 2026
@christos68k

Copy link
Copy Markdown
Member Author

I pushed a commit to update status from Development to Alpha.

@christos68k christos68k mentioned this pull request Mar 19, 2026
2 tasks
Comment thread specification/profiles/README.md Outdated
Comment thread specification/profiles/README.md Outdated
Comment thread specification/profiles/pprof.md
@tigrannajaryan

Copy link
Copy Markdown
Member

Closing/opening to trigger the build.

@tigrannajaryan

Copy link
Copy Markdown
Member

@christos68k can you resolve the conflicts?

@tigrannajaryan

Copy link
Copy Markdown
Member

@jsuereth can you take a look? We need one more approval.

@tigrannajaryan

Copy link
Copy Markdown
Member

@open-telemetry/specs-approvers PTAL

1 similar comment
@tigrannajaryan

Copy link
Copy Markdown
Member

@open-telemetry/specs-approvers PTAL

@github-actions

Copy link
Copy Markdown

This PR was marked stale. It will be closed in 14 days without additional activity.

@github-actions github-actions Bot added the Stale label Apr 17, 2026
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions Bot closed this May 1, 2026
@christos68k christos68k reopened this May 1, 2026
@github-actions github-actions Bot removed the Stale label May 2, 2026
@christos68k

Copy link
Copy Markdown
Member Author

@tigrannajaryan Everything is resolved now and should be ready for merge

@tigrannajaryan

Copy link
Copy Markdown
Member

@christos68k please check the build errors.

@christos68k

Copy link
Copy Markdown
Member Author

@christos68k please check the build errors.

The markdown lint error is due to the missing data-format.md file, which is introduced in this PR (data format) that still needs a second approval.

We can either merge #4932 now, or wait until #4965 gets merged first (hopefully we get a second approval there soon).

@github-actions

Copy link
Copy Markdown

This PR was marked stale. It will be closed in 14 days without additional activity.

@github-actions github-actions Bot added the Stale label May 20, 2026
@tigrannajaryan tigrannajaryan added this pull request to the merge queue May 27, 2026
Merged via the queue into open-telemetry:main with commit f1c6078 May 27, 2026
16 of 18 checks passed
hilmarf pushed a commit to apeirora/opentelemetry-specification that referenced this pull request Jun 1, 2026
…4932)

## Changes

This update takes into account the [recent
introduction](https://github.com/open-telemetry/opentelemetry.io/pull/9339/changes)
of a profiles signal concepts
[page](https://opentelemetry.io/docs/concepts/signals/profiles/),
removes duplicate information and adds more relevant documentation.

There is a follow-up PR
[here](open-telemetry#4965)
that adds the current data format page.

CC: @theletterf @open-telemetry/profiling-maintainers
@open-telemetry/profiling-approvers

* [X] Related issues:
[#7874](open-telemetry/opentelemetry.io#7874)
* [X]
[`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md)
file updated for non-trivial changes
* For trivial changes, include `[chore]` in the PR title to skip the
changelog check

---------

Co-authored-by: Felix Geisendörfer <felix@felixge.de>
@carlosalberto carlosalberto mentioned this pull request Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spec:profiling Related to the specification/profiling directory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants