Add profiles data format#4965
Conversation
Co-authored-by: Roger Coll <roger.coll@elastic.co>
Co-authored-by: Fabrizio Ferri-Benedetti <fabri.ferribenedetti@elastic.co>
aalexand
left a comment
There was a problem hiding this comment.
This looks great, thanks for this work!
Co-authored-by: Alexey Alexandrov <aalexand@users.noreply.github.com>
|
@tigrannajaryan Can you please take another look? It'd be great to have this (and the parent PR here) merged before or close to the Alpha announcement. |
tigrannajaryan
left a comment
There was a problem hiding this comment.
None of my comments are blocking.
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Done |
|
@jsuereth please take a look. |
|
@open-telemetry/specs-approvers PTAL |
Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
|
This PR was marked stale. It will be closed in 14 days without additional activity. |
|
@open-telemetry/spec-sponsors @open-telemetry/specs-approvers please review. |
|
This PR was marked stale. It will be closed in 14 days without additional activity. |
…4932) ## Changes This update takes into account the [recent introduction](https://github.com/open-telemetry/opentelemetry.io/pull/9339/changes) of a profiles signal concepts [page](https://opentelemetry.io/docs/concepts/signals/profiles/), removes duplicate information and adds more relevant documentation. There is a follow-up PR [here](open-telemetry#4965) that adds the current data format page. CC: @theletterf @open-telemetry/profiling-maintainers @open-telemetry/profiling-approvers * [X] Related issues: [#7874](open-telemetry/opentelemetry.io#7874) * [X] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes * For trivial changes, include `[chore]` in the PR title to skip the changelog check --------- Co-authored-by: Felix Geisendörfer <felix@felixge.de>
…4932) ## Changes This update takes into account the [recent introduction](https://github.com/open-telemetry/opentelemetry.io/pull/9339/changes) of a profiles signal concepts [page](https://opentelemetry.io/docs/concepts/signals/profiles/), removes duplicate information and adds more relevant documentation. There is a follow-up PR [here](open-telemetry#4965) that adds the current data format page. CC: @theletterf @open-telemetry/profiling-maintainers @open-telemetry/profiling-approvers * [X] Related issues: [#7874](open-telemetry/opentelemetry.io#7874) * [X] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes * For trivial changes, include `[chore]` in the PR title to skip the changelog check --------- Co-authored-by: Felix Geisendörfer <felix@felixge.de>
|
@christos68k please resolve the conflicts. |
|
This PR was marked stale. It will be closed in 14 days without additional activity. |
Changes
Adds a data format description for OpenTelemetry profiles.
I took some content from the old OTEP but decided to leave all of the historical information out, both for clarity/focus and to improve readability (a technical specification doesn't read very well by nature).
We could add additional references and expand on design decisions in a future
data-format-appendix.mddocument.Also see: #4932 (This PR is a follow-up)
CC: @theletterf @tigrannajaryan @open-telemetry/profiling-maintainers @open-telemetry/profiling-approvers
For non-trivial changes, follow the change proposal process.
CHANGELOG.mdfile updated for non-trivial changes[chore]in the PR title to skip the changelog check