fix: prevent Enter from sending message during IME composition#343
Open
baryhuang wants to merge 1 commit intoopenagents-org:developfrom
Open
fix: prevent Enter from sending message during IME composition#343baryhuang wants to merge 1 commit intoopenagents-org:developfrom
baryhuang wants to merge 1 commit intoopenagents-org:developfrom
Conversation
|
@baryhuang is attempting to deploy a commit to the Raphael's projects Team on Vercel. A member of the Team first needs to authorize it. |
When typing Chinese, Japanese, or Korean using an IME, pressing Enter to confirm a character selection was incorrectly triggering message send. Added isComposing guard to all chat input keydown handlers.
ba3da90 to
6a35c4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isComposingguard at the top ofhandleKeyDownin all 3 chat input components: workspace frontend, packages/go, and studio MessageInputKeyboardEvent.isComposingproperty with aProcesskey fallback for legacy browsersTest plan
🤖 Generated with Claude Code