Skip to content

fix: prevent Enter from sending message during IME composition#343

Open
baryhuang wants to merge 1 commit intoopenagents-org:developfrom
baryhuang:fix/chinese-ime-enter-send
Open

fix: prevent Enter from sending message during IME composition#343
baryhuang wants to merge 1 commit intoopenagents-org:developfrom
baryhuang:fix/chinese-ime-enter-send

Conversation

@baryhuang
Copy link
Copy Markdown
Collaborator

Summary

  • When typing Chinese/Japanese/Korean using an IME, pressing Enter to confirm a character selection was incorrectly triggering message send
  • Added isComposing guard at the top of handleKeyDown in all 3 chat input components: workspace frontend, packages/go, and studio MessageInput
  • Uses the standard KeyboardEvent.isComposing property with a Process key fallback for legacy browsers

Test plan

  • Tested locally with Chinese IME input — Enter confirms character without sending
  • Verify normal Enter-to-send still works without IME active
  • Verify Shift+Enter newline still works
  • Verify @mention selection with Enter still works (without IME)

🤖 Generated with Claude Code

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 12, 2026

@baryhuang is attempting to deploy a commit to the Raphael's projects Team on Vercel.

A member of the Team first needs to authorize it.

When typing Chinese, Japanese, or Korean using an IME, pressing Enter
to confirm a character selection was incorrectly triggering message send.
Added isComposing guard to all chat input keydown handlers.
@baryhuang baryhuang force-pushed the fix/chinese-ime-enter-send branch from ba3da90 to 6a35c4a Compare April 12, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant