Skip to content

fix: prevent Enter from sending message during IME composition #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
baryhuang wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −0
Open

fix: prevent Enter from sending message during IME composition #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/go/components/chat/chat-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ export function ChatInput({ onSend, disabled, className, agents = [], draft, onD
};

const handleKeyDown = (e: React.KeyboardEvent<HTMLTextAreaElement>) => {
// Ignore Enter during IME composition (Chinese, Japanese, Korean input)
if (e.nativeEvent.isComposing || e.key === 'Process') return;

if (showMentions && filteredAgents.length > 0) {
if (e.key === 'ArrowDown') {
e.preventDefault();
Expand Down
3 changes: 3 additions & 0 deletions sdk/studio/src/pages/messaging/components/MessageInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,9 @@ const MessageInput: React.FC<MessageInputProps> = ({
}

const handleKeyDown = (e: React.KeyboardEvent) => {
// Ignore Enter during IME composition (Chinese, Japanese, Korean input)
if (e.nativeEvent.isComposing || e.key === 'Process') return;

// Handle mention navigation
if (showMentions && filteredAgents.length > 0) {
if (e.key === "ArrowDown") {
Expand Down
3 changes: 3 additions & 0 deletions workspace/frontend/components/chat/chat-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,9 @@ export function ChatInput({ onSend, disabled, className, agents = [], draft, onD
};

const handleKeyDown = (e: React.KeyboardEvent<HTMLTextAreaElement>) => {
// Ignore Enter during IME composition (Chinese, Japanese, Korean input)
if (e.nativeEvent.isComposing || e.key === 'Process') return;

if (showMentions && filteredAgents.length > 0) {
if (e.key === 'ArrowDown') {
e.preventDefault();
Expand Down
Loading