8358772: Template-Framework Library: Primitive Types#380
8358772: Template-Framework Library: Primitive Types#380rm-gh-8 wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back rm-gh-8! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8358772: Template-Framework Library: Primitive Types. This is a test fix. For parity with Oracle JDK. It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues: 8358772: Template-Framework Library: Primitive Types |
Backporting JDK-8358772: Template-Framework Library: Primitive Types.
This adds primitive type support to the compiler test template framework library, enabling type-aware code generation for Java primitive types. It is a foundation for additional random expression generation work.
For parity with Oracle JDK.
It is part of a series of dependent PRs for JDK 25, related to the following list of ordered issues:
8358772: Template-Framework Library: Primitive Types
8358600: Template-Framework Library: Template for TestFramework test class
8359412: Template-Framework Library: Operations and Expressions
8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries
8370489: Some compiler tests miss the @key randomness
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/hotspot/jtreg/testlibrary_tests/template_framework
make test TEST=test/hotspot/jtreg/compiler
Results attached:
windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/380/head:pull/380$ git checkout pull/380Update a local copy of the PR:
$ git checkout pull/380$ git pull https://git.openjdk.org/jdk25u-dev.git pull/380/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 380View PR using the GUI difftool:
$ git pr show -t 380Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/380.diff
Using Webrev
Link to Webrev Comment