HYPERFLEET-769 - fix: align broker Helm values with adapter chart snake_case convention

[rafabene]

Summary

• Rename broker googlepubsub Helm value keys from camelCase to snake_case to match the adapter chart convention introduced in HYPERFLEET-551
• Fix deploy-scripts/lib/adapter.sh --set flags: projectId → project_id, subscriptionId → subscription_id, deadLetterTopic → dead_letter_topic, createTopicIfMissing → create_topic_if_missing, createSubscriptionIfMissing → create_subscription_if_missing
• Fix all adapter values.yaml files under testdata/adapter-configs/:
  • 7 configs: rename broker keys from camelCase to snake_case
  • cl-invalid-resource, cl-precondition-error: replace hardcoded ci/hyperfleet-adapter:latest with ${ADAPTER_IMAGE_REPO}:${ADAPTER_IMAGE_TAG}
  • cl-maestro: replace CHANGE_ME placeholders and hardcoded image with env var references

Context

The hyperfleet-adapter chart (HYPERFLEET-551) renamed all config fields from camelCase to snake_case. The E2E repo was not updated, causing Helm to pass empty values to the broker ConfigMap template, which expects snake_case keys (e.g., .Values.broker.googlepubsub.project_id). This resulted in adapter pods crashing on startup.

Test plan

• Run E2E deployment with the updated values and verify adapter pods start successfully
• Verify broker ConfigMap contains correct values (not empty)
• Run tier1 cl-precondition-error test — Applied=False, Available=False, Health=False
• Run tier1 cl-invalid-resource test — adapter failure detection and reporting validated
• Run tier0 cluster and nodepool baseline tests (excluding maestro)

Summary by CodeRabbit

• Chores
  • Standardized Google Pub/Sub broker configuration field names from camelCase to snake_case across deployment and test configurations.
  • Updated test/deployment configs to use templated variables for image registry/repository and tag instead of fixed placeholders.
  • Improved consistency and flexibility of configuration variable substitution patterns.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign yingzhanredhat for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 147e1369-da19-4ce6-bfb8-fbcc2214ec35

📥 Commits

Reviewing files that changed from the base of the PR and between 603460d and e2bdaa3.

📒 Files selected for processing (1)

• testdata/adapter-configs/cl-maestro/values.yaml

✅ Files skipped from review due to trivial changes (1)

• testdata/adapter-configs/cl-maestro/values.yaml

---

Walkthrough

This pull request renames Google Pub/Sub broker configuration keys from camelCase to snake_case across deployment and test data: projectId → project_id, subscriptionId → subscription_id, deadLetterTopic → dead_letter_topic, createTopicIfMissing → create_topic_if_missing, and createSubscriptionIfMissing → create_subscription_if_missing. Changes affect one shell script (deploy-scripts/lib/adapter.sh) and multiple YAML values files under testdata/adapter-configs. No control flow, command structure, parameter values, or exported/public entities were modified.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: renaming broker Helm values from camelCase to snake_case to align with adapter chart convention, which is the primary objective across all modified files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/adapter-broker-snake-case

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}