Skip to content

HYPERFLEET-769 - fix: align broker Helm values with adapter chart snake_case convention #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rafabene wants to merge 3 commits into from
+37 −37
Closed

HYPERFLEET-769 - fix: align broker Helm values with adapter chart snake_case convention #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47dbd6a
fix: align broker Helm values with adapter chart snake_case convention
rafabene Mar 19, 2026
1e18b8d
fix: use env vars for adapter image in error test configs
rafabene Mar 19, 2026
e2bdaa3
fix: use env vars for adapter image in cl-maestro values.yaml
rafabene Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions deploy-scripts/lib/adapter.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,12 +179,12 @@ install_adapter_instance() {
--set "image.registry=${IMAGE_REGISTRY}"
--set "image.repository=${ADAPTER_IMAGE_REPO}"
--set "image.tag=${ADAPTER_IMAGE_TAG}"
--set "broker.googlepubsub.projectId=${GCP_PROJECT_ID}"
--set "broker.googlepubsub.createTopicIfMissing=${ADAPTER_GOOGLEPUBSUB_CREATE_TOPIC_IF_MISSING}"
--set "broker.googlepubsub.createSubscriptionIfMissing=${ADAPTER_GOOGLEPUBSUB_CREATE_SUBSCRIPTION_IF_MISSING}"
--set "broker.googlepubsub.subscriptionId=${subscription_id}"
--set "broker.googlepubsub.project_id=${GCP_PROJECT_ID}"
--set "broker.googlepubsub.create_topic_if_missing=${ADAPTER_GOOGLEPUBSUB_CREATE_TOPIC_IF_MISSING}"
--set "broker.googlepubsub.create_subscription_if_missing=${ADAPTER_GOOGLEPUBSUB_CREATE_SUBSCRIPTION_IF_MISSING}"
--set "broker.googlepubsub.subscription_id=${subscription_id}"
--set "broker.googlepubsub.topic=${topic}"
--set "broker.googlepubsub.deadLetterTopic=${dead_letter_topic}"
--set "broker.googlepubsub.dead_letter_topic=${dead_letter_topic}"
)

log_info "Executing Helm command:"
Expand Down
6 changes: 3 additions & 3 deletions testdata/adapter-configs/cl-deployment/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ adapterTaskConfig:
broker:
create: true
googlepubsub:
projectId: CHANGE_ME
subscriptionId: CHANGE_ME
project_id: CHANGE_ME
subscription_id: CHANGE_ME
topic: CHANGE_ME
deadLetterTopic: CHANGE_ME
dead_letter_topic: CHANGE_ME

image:
registry: CHANGE_ME
Expand Down
14 changes: 7 additions & 7 deletions testdata/adapter-configs/cl-invalid-resource/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@ adapterTaskConfig:
broker:
create: true
googlepubsub:
projectId: ${GCP_PROJECT_ID}
subscriptionId: ${NAMESPACE}-clusters-${ADAPTER_NAME}
project_id: ${GCP_PROJECT_ID}
subscription_id: ${NAMESPACE}-clusters-${ADAPTER_NAME}
topic: ${NAMESPACE}-clusters
deadLetterTopic: ${NAMESPACE}-clusters-dlq
createTopicIfMissing: ${ADAPTER_GOOGLEPUBSUB_CREATE_TOPIC_IF_MISSING}
createSubscriptionIfMissing: ${ADAPTER_GOOGLEPUBSUB_CREATE_SUBSCRIPTION_IF_MISSING}
dead_letter_topic: ${NAMESPACE}-clusters-dlq
create_topic_if_missing: ${ADAPTER_GOOGLEPUBSUB_CREATE_TOPIC_IF_MISSING}
create_subscription_if_missing: ${ADAPTER_GOOGLEPUBSUB_CREATE_SUBSCRIPTION_IF_MISSING}

image:
registry: ${IMAGE_REGISTRY}
repository: ci/hyperfleet-adapter
repository: ${ADAPTER_IMAGE_REPO}
pullPolicy: Always
tag: latest
tag: ${ADAPTER_IMAGE_TAG}

rbac:
resources:
Expand Down
6 changes: 3 additions & 3 deletions testdata/adapter-configs/cl-job/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ adapterTaskConfig:
broker:
create: true
googlepubsub:
projectId: CHANGE_ME
subscriptionId: CHANGE_ME
project_id: CHANGE_ME
subscription_id: CHANGE_ME
topic: CHANGE_ME
deadLetterTopic: CHANGE_ME
dead_letter_topic: CHANGE_ME

image:
registry: CHANGE_ME
Expand Down
12 changes: 6 additions & 6 deletions testdata/adapter-configs/cl-maestro/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,16 @@ adapterTaskConfig:
broker:
create: true
googlepubsub:
projectId: CHANGE_ME
subscriptionId: CHANGE_ME
project_id: CHANGE_ME
subscription_id: CHANGE_ME
topic: CHANGE_ME
deadLetterTopic: CHANGE_ME
dead_letter_topic: CHANGE_ME

image:
registry: CHANGE_ME
repository: ci/hyperfleet-adapter
registry: ${IMAGE_REGISTRY}
repository: ${ADAPTER_IMAGE_REPO}
pullPolicy: Always
tag: latest
tag: ${ADAPTER_IMAGE_TAG}

rbac:
resources:
Expand Down
6 changes: 3 additions & 3 deletions testdata/adapter-configs/cl-namespace/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ adapterTaskConfig:
broker:
create: true
googlepubsub:
projectId: CHANGE_ME
subscriptionId: CHANGE_ME
project_id: CHANGE_ME
subscription_id: CHANGE_ME
topic: CHANGE_ME
deadLetterTopic: CHANGE_ME
dead_letter_topic: CHANGE_ME

image:
registry: CHANGE_ME
Expand Down
14 changes: 7 additions & 7 deletions testdata/adapter-configs/cl-precondition-error/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,18 @@ adapterTaskConfig:
broker:
create: true
googlepubsub:
projectId: ${GCP_PROJECT_ID}
subscriptionId: ${NAMESPACE}-clusters-${ADAPTER_NAME}
project_id: ${GCP_PROJECT_ID}
subscription_id: ${NAMESPACE}-clusters-${ADAPTER_NAME}
topic: ${NAMESPACE}-clusters
deadLetterTopic: ${NAMESPACE}-clusters-dlq
createTopicIfMissing: ${ADAPTER_GOOGLEPUBSUB_CREATE_TOPIC_IF_MISSING}
createSubscriptionIfMissing: ${ADAPTER_GOOGLEPUBSUB_CREATE_SUBSCRIPTION_IF_MISSING}
dead_letter_topic: ${NAMESPACE}-clusters-dlq
create_topic_if_missing: ${ADAPTER_GOOGLEPUBSUB_CREATE_TOPIC_IF_MISSING}
create_subscription_if_missing: ${ADAPTER_GOOGLEPUBSUB_CREATE_SUBSCRIPTION_IF_MISSING}

image:
registry: ${IMAGE_REGISTRY}
repository: ci/hyperfleet-adapter
repository: ${ADAPTER_IMAGE_REPO}
pullPolicy: Always
tag: latest
tag: ${ADAPTER_IMAGE_TAG}

rbac:
resources:
Expand Down
6 changes: 3 additions & 3 deletions testdata/adapter-configs/np-configmap/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ adapterTaskConfig:
broker:
create: true
googlepubsub:
projectId: CHANGE_ME
subscriptionId: CHANGE_ME
project_id: CHANGE_ME
subscription_id: CHANGE_ME
topic: CHANGE_ME
deadLetterTopic: CHANGE_ME
dead_letter_topic: CHANGE_ME

image:
registry: CHANGE_ME
Expand Down