Skip to content

SDN-4773: Add Azure MSI Env Var for ARO HCP#2465

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
bryan-cox:SDN-4773
Aug 8, 2024
Merged

SDN-4773: Add Azure MSI Env Var for ARO HCP#2465
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
bryan-cox:SDN-4773

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

For ARO HCP, we need to be able to override the authentication type to be MSI. For more information please see openshift/enhancements#1659.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Aug 7, 2024

@bryan-cox: This pull request references SDN-4773 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

For ARO HCP, we need to be able to override the authentication type to be MSI. For more information please see openshift/enhancements#1659.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Comment thread pkg/network/cloud_network.go Outdated
For ARO HCP, we need to be able to override the authentication type to be MSI. For more information please see openshift/enhancements#1659.
@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Aug 7, 2024

/lgtm
CI is having a meltdown
/retest

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2024
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 007124e and 2 for PR HEAD fd67779 in total

@bryan-cox
Copy link
Copy Markdown
Member Author

/retest

@bryan-cox
Copy link
Copy Markdown
Member Author

/retest-required

1 similar comment
@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Aug 8, 2024

/retest-required

@kyrtapz
Copy link
Copy Markdown
Contributor

kyrtapz commented Aug 8, 2024

GCP jobs are failing and this change only affects HyperShift deployments.
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 8, 2024

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-gcp-ovn, ci/prow/e2e-gcp-ovn-upgrade

Details

In response to this:

GCP jobs are failing and this change only affects HyperShift deployments.
/override ci/prow/e2e-gcp-ovn
/override ci/prow/e2e-gcp-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 8, 2024

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security fd67779 link false /test security
ci/prow/4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-upgrade fd67779 link false /test 4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-hypershift-ovn-kubevirt fd67779 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-network-mtu-migration-ovn-ipv4 fd67779 link false /test e2e-network-mtu-migration-ovn-ipv4
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 fd67779 link false /test e2e-vsphere-ovn-dualstack-primaryv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit ef5c0ca into openshift:master Aug 8, 2024
@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.18.0-202408081219.p0.gef5c0ca.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants