Skip to content

OCPBUGS-44967: Pass only the certificate name for CNO deployment#5216

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bryan-cox:OCPBUGS-44967
Dec 5, 2024
Merged

OCPBUGS-44967: Pass only the certificate name for CNO deployment#5216
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
bryan-cox:OCPBUGS-44967

Conversation

@bryan-cox
Copy link
Copy Markdown
Member

@bryan-cox bryan-cox commented Dec 2, 2024 •
edited
Loading

What this PR does / why we need it:
Pass only the certificate name for the CNO deployment for managed Azure.
CNO uses its own certificate path here, https://github.com/openshift/cluster-network-operator/blob/7736bfe37f1276f771fcef03077f6d840eb6b862/pkg/network/cloud_network.go#L23.
This is combined with the certificate name here, https://github.com/openshift/cluster-network-operator/blob/7736bfe37f1276f771fcef03077f6d840eb6b862/pkg/network/cloud_network.go#L111.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-44967

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 2, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 2, 2024

@bryan-cox: This pull request references Jira Issue OCPBUGS-44967, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:
Pass only the certificate name for the CNO deployment for managed Azure. CNO uses its own certificate path here, https://github.com/bryan-cox/cluster-network-operator/blob/40e541d2227d2b60cfaa4ea4719ca6923d95e937/pkg/network/cloud_network.go#L23. This is combined with the certificate name here, https://github.com/bryan-cox/cluster-network-operator/blob/40e541d2227d2b60cfaa4ea4719ca6923d95e937/pkg/network/cloud_network.go#L110.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-44967

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Dec 2, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Dec 2, 2024
@openshift-ci openshift-ci Bot requested a review from enxebre December 2, 2024 20:33
@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 2, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 2, 2024

@bryan-cox: This pull request references Jira Issue OCPBUGS-44967, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from isco-rodriguez December 2, 2024 20:33
@openshift-ci openshift-ci Bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Dec 2, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Dec 2, 2024
@bryan-cox bryan-cox force-pushed the OCPBUGS-44967 branch 2 times, most recently from 68aff08 to d5d275d Compare December 2, 2024 20:37
@jparrill
Copy link
Copy Markdown
Contributor

jparrill commented Dec 3, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
enxebre
enxebre reviewed Dec 3, 2024
View reviewed changes
Comment thread control-plane-operator/controllers/hostedcontrolplane/cno/clusternetworkoperator.go Outdated
Value: params.AzureTenantID,
},
corev1.EnvVar{
Name: "ARO_HCP_CLIENT_CERTIFICATE_NAME",
Copy link
Copy Markdown
Member

@enxebre enxebre Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have this in constants as well?

Copy link
Copy Markdown
Member

@enxebre enxebre Dec 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARO_HCP_SECRET_PROVIDER_CLASS / ARO_HCP_CLIENT_CERTIFICATE_NAME

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 3, 2024

/retest-required

Remaining retests: 0 against base HEAD e9fec4b and 2 for PR HEAD d5d275d in total

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@jparrill
Copy link
Copy Markdown
Contributor

jparrill commented Dec 3, 2024

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2024
@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Dec 3, 2024

/retest-required

1 similar comment
@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Dec 3, 2024

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 3, 2024

/retest-required

Remaining retests: 0 against base HEAD e9fec4b and 2 for PR HEAD d776234 in total

@bryan-cox bryan-cox mentioned this pull request Dec 3, 2024
Merged
4 tasks
@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Dec 3, 2024

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 3, 2024

/retest-required

Remaining retests: 0 against base HEAD e9fec4b and 2 for PR HEAD d776234 in total

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Dec 3, 2024

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 3, 2024

/retest-required

Remaining retests: 0 against base HEAD e9fec4b and 2 for PR HEAD d776234 in total

2 similar comments
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 4, 2024

/retest-required

Remaining retests: 0 against base HEAD e9fec4b and 2 for PR HEAD d776234 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 4, 2024

/retest-required

Remaining retests: 0 against base HEAD e9fec4b and 2 for PR HEAD d776234 in total

@enxebre
Copy link
Copy Markdown
Member

enxebre commented Dec 4, 2024

/override ci/prow/e2e-kubevirt-aws-ovn-reduced

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 4, 2024

@enxebre: Overrode contexts on behalf of enxebre: ci/prow/e2e-kubevirt-aws-ovn-reduced

Details

In response to this:

/override ci/prow/e2e-kubevirt-aws-ovn-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Dec 4, 2024

/test e2e-aws

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 4, 2024

/retest-required

Remaining retests: 0 against base HEAD 857ccab and 2 for PR HEAD d776234 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 5, 2024

/retest-required

Remaining retests: 0 against base HEAD 443bf28 and 1 for PR HEAD d776234 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 5, 2024 •
edited
Loading

@bryan-cox: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks d776234 link false /test e2e-aks
ci/prow/okd-scos-e2e-aws-ovn d776234 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bryan-cox
Copy link
Copy Markdown
Member Author

bryan-cox commented Dec 5, 2024

/override ci/prow/e2e-kubevirt-aws-ovn-reduced

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 5, 2024

@bryan-cox: Overrode contexts on behalf of bryan-cox: ci/prow/e2e-kubevirt-aws-ovn-reduced

Details

In response to this:

/override ci/prow/e2e-kubevirt-aws-ovn-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 5d79a32 into openshift:main Dec 5, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 5, 2024

@bryan-cox: Jira Issue OCPBUGS-44967: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44967 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:
Pass only the certificate name for the CNO deployment for managed Azure.
CNO uses its own certificate path here, https://github.com/openshift/cluster-network-operator/blob/7736bfe37f1276f771fcef03077f6d840eb6b862/pkg/network/cloud_network.go#L23.
This is combined with the certificate name here, https://github.com/openshift/cluster-network-operator/blob/7736bfe37f1276f771fcef03077f6d840eb6b862/pkg/network/cloud_network.go#L111.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes OCPBUGS-44967

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox bryan-cox deleted the OCPBUGS-44967 branch December 5, 2024 14:56
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Dec 5, 2024

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202412051538.p0.g5d79a32.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre enxebre left review comments

@isco-rodriguez isco-rodriguez Awaiting requested review from isco-rodriguez

Assignees

@jparrill jparrill

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bryan-cox @openshift-ci-robot @jparrill @enxebre @openshift-bot