NE-2448: Add get_service_endpoints tool for NIDS troubleshooting#144
NE-2448: Add get_service_endpoints tool for NIDS troubleshooting#144openshift-merge-bot[bot] merged 5 commits intoopenshift:mainfrom
Conversation
|
@bentito: This pull request references NE-2448 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
bentito
changed the title
|
@bentito: This pull request references NE-2448 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This refactors query_prometheus to use DynamicClient and NetEdgeTestSuite, aligning with PR openshift#151 and PR openshift#144. Moves query_prometheus to the netedge package to share test infrastructure. Signed-off-by: bentito <btofel@redhat.com>
|
/assign @matzew |
|
@matzew this PR is just a follow-up to make the move to DynamicClient across our toolset |
Thealisyed
left a comment
Thealisyed
left a comment
There was a problem hiding this comment.
This tool returns a raw EndpointSlice JSON. For the LLM agent, would it be helpful to filter or maybe summarize the output (ports, ready status etc..)
Wdyt?
…dpoints This mirrors the changes in PR 147 (inspect_route) to extract key fields like Nodes and Addresses from the EndpointSlice objects and return them alongside the raw data as YAML. Signed-off-by: bentito <btofel@redhat.com>
I think you're correct here too, done in last commit, thanks! |
|
ping @matzew when you can, I think okay for lgtm |
|
/override "Konflux kflux-prd-rh02 / openshift-mcp-server-on-pull-request" |
|
/approve |
openshift-ci
bot
added
the
approved
|
@matzew: Overrode contexts on behalf of matzew: Konflux kflux-prd-rh02 / openshift-mcp-server-on-pull-request DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bentito, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bentito: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit cfa14b8
into
openshift:main
This refactors query_prometheus to use DynamicClient and NetEdgeTestSuite, aligning with PR openshift#151 and PR openshift#144. Moves query_prometheus to the netedge package to share test infrastructure. Signed-off-by: bentito <btofel@redhat.com>
This refactors query_prometheus to use DynamicClient and NetEdgeTestSuite, aligning with PR openshift#151 and PR openshift#144. Moves query_prometheus to the netedge package to share test infrastructure. Signed-off-by: bentito <btofel@redhat.com>
4 participants
Description
This PR implements the
get_service_endpointsMCP tool as part of the NIDS troubleshooting strategy (NE-2278).Changes
get_service_endpointsallows retrieving the fullEndpointsobject for a service.controller-runtimeclient interface to support both live clusters and offline analysis (via potential file-based client injection).fakeclient.Related Resources