Skip to content

neutron_verify: skip FIP ping when pre_launch.bash did not run#1387

Open
rebtoor wants to merge 1 commit into
openstack-k8s-operators:mainfrom
rebtoor:fix/neutron-verify-ipv6-ping
Open

neutron_verify: skip FIP ping when pre_launch.bash did not run#1387
rebtoor wants to merge 1 commit into
openstack-k8s-operators:mainfrom
rebtoor:fix/neutron-verify-ipv6-ping

Conversation

@rebtoor
Copy link
Copy Markdown
Contributor

@rebtoor rebtoor commented May 13, 2026

Problem

The FIP connectivity check in neutron_verify.yaml always ran when
prelaunch_test_instance was true, regardless of which pre-launch
scripts actually executed. When only pre_launch_ironic.bash runs
(e.g. test_with_ceph_and_ironic), no floating IP is created on the
public network, so the ping fails.

This is particularly visible in IPv6 scenarios like uni04delta-ipv6
where the public_subnet_fip_1 default (192.168.122.20) is an IPv4
address unreachable on a pure-IPv6 network, causing:

fatal: [localhost]: FAILED! => {"cmd": "ping -c4 192.168.122.20",
  "stderr": "ping: connect: Network is unreachable", "rc": 2}

Fix

  • Guard the task with 'pre_launch.bash' in prelaunch_test_instance_scripts,
    matching the pattern already used in octavia_post.yaml and nova_verify.yaml
    (ironic task).
  • Replace the hardcoded ping with the ping_command variable for consistency
    with pre_launch.bash.j2 and BGP scenario support.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 13, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign archana203 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

The FIP connectivity check always ran when prelaunch_test_instance was
true, regardless of which pre-launch scripts actually executed. When
only pre_launch_ironic.bash runs (e.g. test_with_ceph_and_ironic), no
floating IP is created on the public network, so the ping fails.

This is particularly visible in IPv6 scenarios like uni04delta-ipv6
where the public_subnet_fip_1 default (192.168.122.20) is an IPv4
address unreachable on a pure-IPv6 network.

Guard the task with the same pre_launch.bash check already used in
octavia_post.yaml and nova_verify.yaml (ironic task). Also replace the
hardcoded 'ping' with the ping_command variable for consistency with
pre_launch.bash.j2 and BGP scenario support.

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
@rebtoor rebtoor force-pushed the fix/neutron-verify-ipv6-ping branch from 1aea836 to c645091 Compare May 13, 2026 12:06
@centosinfra-prod-github-app
Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/2ed8364e6c09436b928b257814b065a1

✔️ noop SUCCESS in 0s
adoption-standalone-to-crc-ceph POST_FAILURE in 3h 08m 19s
✔️ adoption-standalone-to-crc-no-ceph SUCCESS in 3h 10m 47s

@rebtoor
Copy link
Copy Markdown
Contributor Author

rebtoor commented May 14, 2026

recheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant