neutron_verify: skip FIP ping when pre_launch.bash did not run#1387
Open
rebtoor wants to merge 1 commit into
Open
neutron_verify: skip FIP ping when pre_launch.bash did not run#1387rebtoor wants to merge 1 commit into
rebtoor wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The FIP connectivity check always ran when prelaunch_test_instance was true, regardless of which pre-launch scripts actually executed. When only pre_launch_ironic.bash runs (e.g. test_with_ceph_and_ironic), no floating IP is created on the public network, so the ping fails. This is particularly visible in IPv6 scenarios like uni04delta-ipv6 where the public_subnet_fip_1 default (192.168.122.20) is an IPv4 address unreachable on a pure-IPv6 network. Guard the task with the same pre_launch.bash check already used in octavia_post.yaml and nova_verify.yaml (ironic task). Also replace the hardcoded 'ping' with the ping_command variable for consistency with pre_launch.bash.j2 and BGP scenario support. Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
1aea836 to
c645091
Compare
|
Build failed (check pipeline). Post ✔️ noop SUCCESS in 0s |
Contributor
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The FIP connectivity check in
neutron_verify.yamlalways ran whenprelaunch_test_instancewas true, regardless of which pre-launchscripts actually executed. When only
pre_launch_ironic.bashruns(e.g.
test_with_ceph_and_ironic), no floating IP is created on thepublic network, so the ping fails.
This is particularly visible in IPv6 scenarios like
uni04delta-ipv6where the
public_subnet_fip_1default (192.168.122.20) is an IPv4address unreachable on a pure-IPv6 network, causing:
Fix
'pre_launch.bash' in prelaunch_test_instance_scripts,matching the pattern already used in
octavia_post.yamlandnova_verify.yaml(ironic task).
pingwith theping_commandvariable for consistencywith
pre_launch.bash.j2and BGP scenario support.