Skip to content

neutron_verify, nova_verify: skip pre_launch.bash checks when it did not run #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebtoor wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −6
Open

neutron_verify, nova_verify: skip pre_launch.bash checks when it did not run #1387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/roles/dataplane_adoption/tasks/neutron_verify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,11 @@
success_msg: "neutron-dhcp-agent is ALIVE after adoption"

- name: verify connectivity to the existing test VM instance using Floating IP
when: prelaunch_test_instance|bool
when:
- prelaunch_test_instance|bool
- "'pre_launch.bash' in prelaunch_test_instance_scripts"
ansible.builtin.shell: |
ping -c4 {{ lookup('env', 'FIP') | default(public_subnet_fip_1, True) }}
{{ ping_command }} -c4 {{ lookup('env', 'FIP') | default(public_subnet_fip_1, True) }}

- name: validate pings, new workloads after adoption and cleanup
when: neutron_qe_test | default('false') | bool
Expand Down
16 changes: 12 additions & 4 deletions tests/roles/dataplane_adoption/tasks/nova_verify.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,18 @@
alias openstack="oc exec -t openstackclient -- openstack"

- name: verify if the image save works
when: prelaunch_test_instance|bool
when:
- prelaunch_test_instance|bool
- "'pre_launch.bash' in prelaunch_test_instance_scripts"
ansible.builtin.shell: |
{{ nova_header }}
${BASH_ALIASES[openstack]} image save cirros --file /tmp/cirrossave.img

# NOTE(bogdando): do not use 'set -o pipefail' for these verifications
- name: verify if the existing test VM instance is running
when: prelaunch_test_instance|bool
when:
- prelaunch_test_instance|bool
- "'pre_launch.bash' in prelaunch_test_instance_scripts"
ansible.builtin.shell: |
{{ nova_header }}
${BASH_ALIASES[openstack]} server --os-compute-api-version 2.48 show --diagnostics test 2>&1 || echo FAIL
Expand All @@ -21,7 +25,9 @@
- ("FAIL" in nova_verify_running_result.stdout_lines)

- name: verify if the Compute services can stop the existing test VM instance
when: prelaunch_test_instance|bool
when:
- prelaunch_test_instance|bool
- "'pre_launch.bash' in prelaunch_test_instance_scripts"
ansible.builtin.shell: |
{{ nova_header }}
${BASH_ALIASES[openstack]} server list -c Name -c Status -f value | grep -qF "test ACTIVE" && ${BASH_ALIASES[openstack]} server stop test || echo PASS
Expand All @@ -35,7 +41,9 @@
delay: "{{ dataplane_retry_delay }}"

- name: verify if the Compute services can start the existing test VM instance
when: prelaunch_test_instance|bool
when:
- prelaunch_test_instance|bool
- "'pre_launch.bash' in prelaunch_test_instance_scripts"
ansible.builtin.shell: |
{{ nova_header }}
${BASH_ALIASES[openstack]} server list -c Name -c Status -f value | grep -qF "test SHUTOFF" && ${BASH_ALIASES[openstack]} server start test || echo PASS
Expand Down
Loading