Skip to content

Keep deployment patches in kustomization#81

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
lpiwowar:lpiwowar/address-gorkas-comment
Feb 17, 2026
Merged

Keep deployment patches in kustomization#81
openshift-merge-bot[bot] merged 1 commit into
openstack-lightspeed:mainfrom
lpiwowar:lpiwowar/address-gorkas-comment

Conversation

@lpiwowar

Copy link
Copy Markdown
Contributor

Retain patch modifications in config/manager/kustomization.yaml instead of removing them after bundle generation. This aligns with the pattern used in the openstack-k8s-operators namespace.

The Makefile no longer removes the deployment patch, keeping the kustomization file consistent with the generated bundle.

Implements request in this comment [1].

[1] #80 (comment)

Retain patch modifications in config/manager/kustomization.yaml
instead of removing them after bundle generation. This aligns with
the pattern used in the openstack-k8s-operators namespace.

The Makefile no longer removes the deployment patch, keeping the
kustomization file consistent with the generated bundle.

Implements request in this comment [1].

[1] openstack-lightspeed#80 (comment)
@openshift-ci openshift-ci Bot requested review from Akrog and umago February 11, 2026 14:58
@openshift-ci

openshift-ci Bot commented Feb 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@umago

umago commented Feb 11, 2026

Copy link
Copy Markdown
Contributor

Code looks good to me! Not setting the label since I want @Akrog to take a look as he is the original person commenting on this

@umago

umago commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Feb 17, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 0cda86c into openstack-lightspeed:main Feb 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants