Skip to content

commitlint#329

Merged
jamescmartinez merged 5 commits intomainfrom
commitlint
Feb 23, 2026
Merged

commitlint#329
jamescmartinez merged 5 commits intomainfrom
commitlint

Conversation

@jamescmartinez
Copy link
Copy Markdown
Contributor

  • chore: set up commitlint via Husky commit-msg hook
  • chore: add commitlint to CI

Copilot AI review requested due to automatic review settings February 23, 2026 15:52
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Feb 23, 2026

Open in StackBlitz

npm i https://pkg.pr.new/openworkflowdev/openworkflow/@openworkflow/cli@329
npm i https://pkg.pr.new/openworkflowdev/openworkflow/@openworkflow/dashboard@329
npm i https://pkg.pr.new/openworkflowdev/openworkflow@329

commit: 99baa20

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Sets up commit message linting across the repo by adding commitlint configuration, wiring it into local Git hooks via Husky, and introducing a dedicated CI job to validate commit messages.

Changes:

  • Add Husky + commitlint devDependencies and enable Husky via the prepare script.
  • Introduce commitlint.config.js and a commit-msg hook to lint commit messages locally.
  • Add a commitlint job to the GitHub Actions CI workflow.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Adds commitlint + Husky dependencies and enables Husky via prepare.
package-lock.json Locks newly added commitlint/Husky dependency tree.
eslint.config.js Excludes commitlint.config.js from ESLint processing.
commitlint.config.js Adds conventional-commits commitlint configuration.
.husky/commit-msg Adds commit-msg hook intended to run commitlint.
.github/workflows/ci.yaml Adds CI job to run commitlint on push/PR commits.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .husky/commit-msg Outdated
@@ -0,0 +1 @@
npx --no -- commitlint --edit $1
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hook file lacks a shebang (and the usual Husky bootstrap), so Git may fail to execute it on Unix-like systems with an “Exec format error”. Add the standard #!/usr/bin/env sh header (and, if intended, source .husky/_/husky.sh) so the hook runs reliably across environments.

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/ci.yaml
Comment thread .github/workflows/ci.yaml
Copilot AI review requested due to automatic review settings February 23, 2026 16:07
@jamescmartinez jamescmartinez merged commit 0762047 into main Feb 23, 2026
10 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .husky/commit-msg
@@ -0,0 +1,3 @@
#!/usr/bin/env sh
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.husky/commit-msg is missing a shebang and Husky bootstrap line. Git hooks are executed as standalone scripts; without #!/usr/bin/env sh (and, for Husky installs, sourcing .husky/_/husky.sh) this hook can fail to run with an “exec format error” or miss Husky’s PATH setup on some environments. Consider also quoting the commit message path argument to be safe.

Suggested change
#!/usr/bin/env sh
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/ci.yaml
- uses: actions/setup-node@v6
with:
node-version-file: package.json
- run: npm install -D @commitlint/cli @commitlint/config-conventional
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commitlint CI job installs commitlint via npm install -D ... even though commitlint is already in devDependencies. This makes the job non-reproducible (can update the lockfile / resolve ranges differently) and slower than necessary; prefer npm ci (or npm ci --ignore-scripts) and then run commitlint from the installed dependencies.

Suggested change
- run: npm install -D @commitlint/cli @commitlint/config-conventional
- run: npm ci

Copilot uses AI. Check for mistakes.
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants