Skip to content

commitlint #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescmartinez merged 5 commits into from
Feb 23, 2026
Merged

commitlint #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c2c056e
chore: set up commitlint via Husky commit-msg hook
jamescmartinez Feb 23, 2026
a46824e
chore: add commitlint to CI
jamescmartinez Feb 23, 2026
fa930bc
chore: set commitlint fetch-depth to 0
jamescmartinez Feb 23, 2026
b9132ba
chore: update bun CI step to use npm ci to fix bun.lock errors
jamescmartinez Feb 23, 2026
99baa20
chore: add shebang to commit-msg hook
jamescmartinez Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,26 @@ jobs:
--health-retries 5
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version-file: package.json
- uses: oven-sh/setup-bun@v2
- run: bun ci
- run: npm ci
- run: bun run ci:bun
# https://commitlint.js.org/guides/ci-setup.html
commitlint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v6
Comment thread
jamescmartinez marked this conversation as resolved.
with:
fetch-depth: 0
- uses: actions/setup-node@v6
with:
node-version-file: package.json
- run: npm install -D @commitlint/cli @commitlint/config-conventional
Comment thread
jamescmartinez marked this conversation as resolved.
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commitlint CI job installs commitlint via npm install -D ... even though commitlint is already in devDependencies. This makes the job non-reproducible (can update the lockfile / resolve ranges differently) and slower than necessary; prefer npm ci (or npm ci --ignore-scripts) and then run commitlint from the installed dependencies.

Suggested change
- run: npm install -D @commitlint/cli @commitlint/config-conventional
- run: npm ci

Copilot uses AI. Check for mistakes.
- name: Validate current commit (last commit) with commitlint
if: github.event_name == 'push'
run: npx commitlint --last --verbose
- name: Validate PR commits with commitlint
if: github.event_name == 'pull_request'
run: npx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose
3 changes: 3 additions & 0 deletions .husky/commit-msg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/usr/bin/env sh
Copy link

Copilot AI Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.husky/commit-msg is missing a shebang and Husky bootstrap line. Git hooks are executed as standalone scripts; without #!/usr/bin/env sh (and, for Husky installs, sourcing .husky/_/husky.sh) this hook can fail to run with an “exec format error” or miss Husky’s PATH setup on some environments. Consider also quoting the commit message path argument to be safe.

Suggested change
#!/usr/bin/env sh
#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

Copilot uses AI. Check for mistakes.

npx --no -- commitlint --edit "$1"
1 change: 1 addition & 0 deletions commitlint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export default { extends: ["@commitlint/config-conventional"] };
7 changes: 4 additions & 3 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,13 @@ export default defineConfig(
{
ignores: [
"**/dist",
"coverage",
"eslint.config.js",
"prettier.config.js",
"examples/workflow-discovery/openworkflow.config.js",
"packages/dashboard/.output",
"packages/dashboard/src/routeTree.gen.ts",
"commitlint.config.js",
"coverage",
"eslint.config.js",
"prettier.config.js",
],
},
{
Expand Down
Loading
Loading