Skip to content

test: widen timing bounds for flaky step retry-budget tests#473

Merged
jamescmartinez merged 1 commit intomainfrom
flaky-test
Apr 17, 2026
Merged

test: widen timing bounds for flaky step retry-budget tests#473
jamescmartinez merged 1 commit intomainfrom
flaky-test

Conversation

@jamescmartinez
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings April 17, 2026 18:14
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Apr 17, 2026

Open in StackBlitz

npm i https://pkg.pr.new/openworkflowdev/openworkflow/@openworkflow/cli@473
npm i https://pkg.pr.new/openworkflowdev/openworkflow/@openworkflow/dashboard@473
npm i https://pkg.pr.new/openworkflowdev/openworkflow@473

commit: fcc2e15

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces flakiness in worker retry-budget timing tests by widening real-time sleep durations and loosening upper-bound assertions on computed retry delays.

Changes:

  • Increased post-tick() sleep from 100ms → 200ms in two retry-budget-related tests.
  • Relaxed retry delay upper-bound expectations from ~220–230ms → 350ms to better tolerate scheduler/CI jitter.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jamescmartinez jamescmartinez merged commit f541fd3 into main Apr 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants