Skip to content

test: widen timing bounds for flaky step retry-budget tests #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamescmartinez merged 1 commit into from
Apr 17, 2026
Merged

test: widen timing bounds for flaky step retry-budget tests #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/openworkflow/worker/worker.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,7 +1664,7 @@ describe("Worker", () => {

await sleep(100);
await worker.tick();
await sleep(100);
await sleep(200);

const afterSecond = await backend.getWorkflowRun({
workflowRunId: handle.workflowRun.id,
Expand Down Expand Up @@ -1734,7 +1734,7 @@ describe("Worker", () => {
if (!run?.availableAt) throw new Error("Expected availableAt");
const firstDelayMs = run.availableAt.getTime() - beforeFirst;
expect(firstDelayMs).toBeGreaterThanOrEqual(80);
expect(firstDelayMs).toBeLessThan(220);
expect(firstDelayMs).toBeLessThan(350);

await sleep(180);
const beforeSecond = Date.now();
Expand All @@ -1760,7 +1760,7 @@ describe("Worker", () => {
if (!run?.availableAt) throw new Error("Expected availableAt");
const thirdDelayMs = run.availableAt.getTime() - beforeThird;
expect(thirdDelayMs).toBeGreaterThanOrEqual(80);
expect(thirdDelayMs).toBeLessThan(220);
expect(thirdDelayMs).toBeLessThan(350);

await sleep(180);
await worker.tick();
Expand Down Expand Up @@ -1830,15 +1830,15 @@ describe("Worker", () => {
// first failed step attempt should still use attempt 1 backoff (100ms)
const beforeFirstFail = Date.now();
await worker.tick();
await sleep(100);
await sleep(200);
run = await backend.getWorkflowRun({
workflowRunId: handle.workflowRun.id,
});
expect(run?.status).toBe("pending");
if (!run?.availableAt) throw new Error("Expected availableAt");
const firstDelayMs = run.availableAt.getTime() - beforeFirstFail;
expect(firstDelayMs).toBeGreaterThanOrEqual(80);
expect(firstDelayMs).toBeLessThan(230);
expect(firstDelayMs).toBeLessThan(350);

await sleep(220);

Expand Down
Loading