Skip to content

luci-theme-material: fix overview spacing#8508

Closed
owlsy wants to merge 1 commit intoopenwrt:masterfrom
owlsy:luci-theme-material-overview-spacing
Closed

luci-theme-material: fix overview spacing#8508
owlsy wants to merge 1 commit intoopenwrt:masterfrom
owlsy:luci-theme-material-overview-spacing

Conversation

@owlsy
Copy link
Copy Markdown
Contributor

@owlsy owlsy commented Apr 2, 2026

Changes

  • Resolve mismatched spacing for each heading in their box. This will fix the spacing for when contents are hidden and add spacing when contents are shown. Compliments the hide/show buttons added.

Notes

Checklist

  • This PR is not from my main or master branch 💩, but a separate branch ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff)
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages
  • Incremented 🆙 any PKG_VERSION in the Makefile
  • Tested on: (architecture, openwrt version, browser) ✅
  • ( Preferred ) Mention: @ the original code author for feedback
  • ( Preferred ) Screenshot or mp4 of changes:
  • Description: (describe the changes proposed in this PR)

@owlsy
Copy link
Copy Markdown
Contributor Author

owlsy commented Apr 2, 2026

Will need assistance. How do I revert changes from this pull request so it is up to date with master, then apply the requested change again to the file?

Edit: Just going to make a new pull request as I can't remove the latest commit, I had trouble figuring it out without making more of a mess.

@owlsy owlsy force-pushed the luci-theme-material-overview-spacing branch from 618a0a8 to 7bf41ca Compare April 2, 2026 22:01
@github-actions

This comment has been minimized.

@owlsy owlsy marked this pull request as draft April 2, 2026 22:46
@owlsy owlsy closed this Apr 2, 2026
@owlsy owlsy deleted the luci-theme-material-overview-spacing branch April 2, 2026 22:52
@owlsy
Copy link
Copy Markdown
Contributor Author

owlsy commented Apr 2, 2026

Messed up the commits and couldn't resolve it. Closing and trying again with #8519.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 3, 2026

Warning

Some formality checks failed.

Consider (re)reading submissions guidelines.

Failed checks

Issues marked with an ❌ are failing checks.

Commit 7bf41ca

  • Signed-off-by must match author
    Actual: missing or doesn't match author
    Expected: Signed-off-by: Joshua Criss <owlsy@outlook.com.au>

For more details, see the full job log.

Something broken? Consider providing feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant