🌱 Pass all feature gates explicitly in controller deployments#2700
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR makes feature gate configuration fully explicit in rendered deployments by ensuring every controller deployment variant passes all known feature gates via --feature-gates arguments, instead of relying on implicit binary defaults.
Changes:
- Populate Helm default values (
helm/olmv1/values.yaml) with all feature gates at their default enabled/disabled states. - Update experimental Helm values (
helm/experimental.yaml) to include all feature gates and keep lists consistent/alphabetized. - Regenerate rendered manifests so
standard,standard-e2e,experimental, andexperimental-e2edeployments include explicit feature gate args.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| manifests/standard.yaml | Adds explicit --feature-gates=... args for catalogd and operator-controller in the standard install manifest. |
| manifests/standard-e2e.yaml | Adds explicit --feature-gates=... args for catalogd and operator-controller in the standard e2e manifest. |
| manifests/experimental.yaml | Reorders/completes feature gate args in the experimental manifest (including missing gates). |
| manifests/experimental-e2e.yaml | Reorders/completes feature gate args in the experimental e2e manifest (including missing gates). |
| helm/olmv1/values.yaml | Sets default feature gate enabled/disabled lists to explicitly reflect intended defaults. |
| helm/experimental.yaml | Ensures experimental values enumerate all feature gates (including missing ones) and adds explicit empty disabled list for catalogd. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| disabled: [] | ||
| enabled: | ||
| - WebhookProviderCertManager | ||
| - WebhookProviderOpenshiftServiceCA |
There was a problem hiding this comment.
Basically, this copilot comment is my concern.
Previously, only non-default feature gates were passed as --feature-gates args to controller pods. Standard deployments had no feature gate args at all, and experimental deployments only listed flags that differed from defaults. This made it impossible to determine the active feature gate configuration by inspecting a running deployment or pod spec. Now all 10 feature gates (9 operator-controller + 1 catalogd) are listed explicitly in every deployment variant, improving readability when inspecting deployments or pods. WebhookProviderOpenshiftServiceCA is listed as disabled in standard defaults because getCertificateProvider() checks WebhookProviderCertManager first — when both are enabled, OpenshiftServiceCA has no effect. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pedjak
force-pushed
the
explicit-feature-flags
branch
from
365064d to
fc1fda4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2700 +/- ##
==========================================
- Coverage 68.12% 68.10% -0.02%
==========================================
Files 145 145
Lines 10700 10700
==========================================
- Hits 7289 7287 -2
- Misses 2884 2885 +1
- Partials 527 528 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/approve |
openshift-ci
Bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rashmigottipati, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit c02fe46
into
operator-framework:main
Description
Previously, only non-default feature gates were passed as
--feature-gatesargs to controller pods:
This made it impossible to determine the active feature gate configuration
by inspecting a running deployment or pod spec — you had to cross-reference
the Go source code to know the defaults.
Now all 10 feature gates (9 operator-controller + 1 catalogd) are listed
explicitly in every deployment variant (standard, standard-e2e, experimental,
experimental-e2e), improving readability when inspecting deployments or pods.
Changes
helm/olmv1/values.yaml: Populated emptyenabled/disabledlists withall feature gates at their default values
helm/experimental.yaml: Added missing feature gates (WebhookProviderCertManager,SyntheticPermissions) so all flags are listed; sorted alphabeticallymanifests/*.yaml: RegeneratedReviewer Checklist