Skip to content

🌱 Pass all feature gates explicitly in controller deployments #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
May 13, 2026
Merged

🌱 Pass all feature gates explicitly in controller deployments #2700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions helm/experimental.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,15 @@ options:
replicas: 2
features:
enabled:
- SingleOwnNamespaceInstallSupport
- PreflightPermissions
- HelmChartSupport
- BoxcutterRuntime
- DeploymentConfig
- BundleReleaseSupport
- DeploymentConfig
- HelmChartSupport
- PreflightPermissions
- SingleOwnNamespaceInstallSupport
- WebhookProviderCertManager
disabled:
- SyntheticPermissions
- WebhookProviderOpenshiftServiceCA
# List of enabled experimental features for catalogd
# Use with {{- if has "FeatureGate" .Values.options.catalogd.features.enabled }}
Expand All @@ -28,5 +30,6 @@ options:
features:
enabled:
- APIV1MetasHandler
disabled: []
# This can be one of: standard or experimental
featureSet: experimental
16 changes: 13 additions & 3 deletions helm/olmv1/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,17 @@ options:
replicas: 1
extraArguments: []
features:
enabled: []
disabled: []
enabled:
- WebhookProviderCertManager
disabled:
- BoxcutterRuntime
- BundleReleaseSupport
- DeploymentConfig
- HelmChartSupport
- PreflightPermissions
- SingleOwnNamespaceInstallSupport
- SyntheticPermissions
- WebhookProviderOpenshiftServiceCA
podDisruptionBudget:
enabled: true
minAvailable: 1
Expand All @@ -24,7 +33,8 @@ options:
extraArguments: []
features:
enabled: []
disabled: []
disabled:
- APIV1MetasHandler
podDisruptionBudget:
enabled: true
minAvailable: 1
Expand Down
10 changes: 6 additions & 4 deletions manifests/experimental-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2823,12 +2823,14 @@ spec:
- --metrics-bind-address=:8443
- --pprof-bind-address=:6060
- --leader-elect
- --feature-gates=SingleOwnNamespaceInstallSupport=true
- --feature-gates=PreflightPermissions=true
- --feature-gates=HelmChartSupport=true
- --feature-gates=BoxcutterRuntime=true
- --feature-gates=DeploymentConfig=true
- --feature-gates=BundleReleaseSupport=true
- --feature-gates=DeploymentConfig=true
- --feature-gates=HelmChartSupport=true
- --feature-gates=PreflightPermissions=true
- --feature-gates=SingleOwnNamespaceInstallSupport=true
- --feature-gates=WebhookProviderCertManager=true
- --feature-gates=SyntheticPermissions=false
- --feature-gates=WebhookProviderOpenshiftServiceCA=false
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
Expand Down
10 changes: 6 additions & 4 deletions manifests/experimental.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2729,12 +2729,14 @@ spec:
- --health-probe-bind-address=:8081
- --metrics-bind-address=:8443
- --leader-elect
- --feature-gates=SingleOwnNamespaceInstallSupport=true
- --feature-gates=PreflightPermissions=true
- --feature-gates=HelmChartSupport=true
- --feature-gates=BoxcutterRuntime=true
- --feature-gates=DeploymentConfig=true
- --feature-gates=BundleReleaseSupport=true
- --feature-gates=DeploymentConfig=true
- --feature-gates=HelmChartSupport=true
- --feature-gates=PreflightPermissions=true
- --feature-gates=SingleOwnNamespaceInstallSupport=true
- --feature-gates=WebhookProviderCertManager=true
- --feature-gates=SyntheticPermissions=false
- --feature-gates=WebhookProviderOpenshiftServiceCA=false
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
Expand Down
10 changes: 10 additions & 0 deletions manifests/standard-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1805,6 +1805,7 @@ spec:
- --metrics-bind-address=:7443
- --pprof-bind-address=:6060
- --external-address=catalogd-service.olmv1-system.svc
- --feature-gates=APIV1MetasHandler=false
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
- --pull-cas-dir=/var/ca-certs
Expand Down Expand Up @@ -1955,6 +1956,15 @@ spec:
- --metrics-bind-address=:8443
- --pprof-bind-address=:6060
- --leader-elect
- --feature-gates=WebhookProviderCertManager=true
- --feature-gates=BoxcutterRuntime=false
- --feature-gates=BundleReleaseSupport=false
- --feature-gates=DeploymentConfig=false
- --feature-gates=HelmChartSupport=false
- --feature-gates=PreflightPermissions=false
- --feature-gates=SingleOwnNamespaceInstallSupport=false
- --feature-gates=SyntheticPermissions=false
- --feature-gates=WebhookProviderOpenshiftServiceCA=false
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
- --catalogd-cas-dir=/var/ca-certs
Expand Down
10 changes: 10 additions & 0 deletions manifests/standard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1724,6 +1724,7 @@ spec:
- --leader-elect
- --metrics-bind-address=:7443
- --external-address=catalogd-service.olmv1-system.svc
- --feature-gates=APIV1MetasHandler=false
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
- --pull-cas-dir=/var/ca-certs
Expand Down Expand Up @@ -1861,6 +1862,15 @@ spec:
- --health-probe-bind-address=:8081
- --metrics-bind-address=:8443
- --leader-elect
- --feature-gates=WebhookProviderCertManager=true
- --feature-gates=BoxcutterRuntime=false
- --feature-gates=BundleReleaseSupport=false
- --feature-gates=DeploymentConfig=false
- --feature-gates=HelmChartSupport=false
- --feature-gates=PreflightPermissions=false
- --feature-gates=SingleOwnNamespaceInstallSupport=false
- --feature-gates=SyntheticPermissions=false
- --feature-gates=WebhookProviderOpenshiftServiceCA=false
- --tls-cert=/var/certs/tls.crt
- --tls-key=/var/certs/tls.key
- --catalogd-cas-dir=/var/ca-certs
Expand Down