[#654] 스토어 배포 빌드에서 FUNCTION_API_BASE_URL 설정을 검증한다#655
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
이번 PR은 Fastfile에 FUNCTION_API_BASE_URL 검증 로직을 추가하고, 기존 verify_firestore_database_id 프라이빗 레인을 verify_store_info_plist로 변경하였습니다. 리뷰어는 이 변경으로 인해 upload_testflight_build 및 upload_appstore_build 레인에서 여전히 존재하지 않는 기존 레인을 호출하여 런타임 에러가 발생할 수 있는 문제를 정확히 지적하였으며, 이에 대한 수정 가이드를 제공했습니다.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 연관된 이슈
🎯 의도
FUNCTION_API_BASE_URL설정 누락 또는 오설정을 빌드 단계에서 감지하도록 개선📝 작업 내용
📌 요약
Info.plist검증 범위를FIRESTORE_DATABASE_ID에서FUNCTION_API_BASE_URL까지 확장🔍 상세
Info.plist에서FUNCTION_API_BASE_URL을 읽어 기대값과 다르면 fastlane lane 실패 처리FIRESTORE_DATABASE_ID검증 흐름은 유지하면서 스토어 설정 검증 lane으로 확장📸 영상 / 이미지 (Optional)