Skip to content

[#654] 스토어 배포 빌드에서 FUNCTION_API_BASE_URL 설정을 검증한다 #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
opficdev merged 3 commits into from
Jun 27, 2026
+59 −18
Merged

[#654] 스토어 배포 빌드에서 FUNCTION_API_BASE_URL 설정을 검증한다 #655

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
00c9964
fix: 배포 빌드 API URL 검증 추가
opficdev Jun 27, 2026
4749fe0
fix: 업로드 lane 설정 검증 호출 수정
opficdev Jun 27, 2026
bc0c5f2
chore: 배포 lane API URL 인자 명시
opficdev Jun 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 59 additions & 18 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ TESTFLIGHT_CONFIGURATION = "Staging"
APPSTORE_CONFIGURATION = "Release"
TESTFLIGHT_DATABASE_ID = "staging"
APPSTORE_DATABASE_ID = "prod"
TESTFLIGHT_FUNCTION_API_BASE_URL = "https://asia-northeast3-devlog-c87b6.cloudfunctions.net/stagingApi/api"
APPSTORE_FUNCTION_API_BASE_URL = "https://asia-northeast3-devlog-c87b6.cloudfunctions.net/prodApi/api"
TESTFLIGHT_BUILD_OUTPUT_DIRECTORY = File.expand_path("testflight_build", __dir__)
TESTFLIGHT_IPA_OUTPUT_PATH = File.join(TESTFLIGHT_BUILD_OUTPUT_DIRECTORY, "#{APP_PRODUCT_NAME}.ipa")
APPSTORE_BUILD_OUTPUT_DIRECTORY = File.expand_path("appstore_build", __dir__)
Expand Down Expand Up @@ -60,37 +62,53 @@ platform :ios do
private_lane :verify_store_configuration do |options|
configuration = options[:configuration].to_s.strip
database_id = options[:database_id].to_s.strip
function_api_base_url = options[:function_api_base_url].to_s.strip

expected_database_id =
expected_configuration =
case configuration
when TESTFLIGHT_CONFIGURATION
TESTFLIGHT_DATABASE_ID
{
database_id: TESTFLIGHT_DATABASE_ID,
function_api_base_url: TESTFLIGHT_FUNCTION_API_BASE_URL
}
when APPSTORE_CONFIGURATION
APPSTORE_DATABASE_ID
{
database_id: APPSTORE_DATABASE_ID,
function_api_base_url: APPSTORE_FUNCTION_API_BASE_URL
}
else
UI.user_error!("Unsupported store configuration: #{configuration}")
end

UI.user_error!("Missing Firestore database ID for #{configuration}") if database_id.empty?
UI.user_error!("Missing Function API base URL for #{configuration}") if function_api_base_url.empty?

if database_id != expected_database_id
if database_id != expected_configuration[:database_id]
UI.user_error!(
"Invalid store configuration: #{configuration} must use FIRESTORE_DATABASE_ID=#{expected_database_id}, got #{database_id}"
"Invalid store configuration: #{configuration} must use FIRESTORE_DATABASE_ID=#{expected_configuration[:database_id]}, got #{database_id}"
)
end

UI.message("Verified store configuration: #{configuration}/#{database_id}")
if function_api_base_url != expected_configuration[:function_api_base_url]
UI.user_error!(
"Invalid store configuration: #{configuration} must use FUNCTION_API_BASE_URL=#{expected_configuration[:function_api_base_url]}, got #{function_api_base_url}"
)
end

UI.message("Verified store configuration: #{configuration}/#{database_id}/#{function_api_base_url}")
end

private_lane :verify_firestore_database_id do |options|
private_lane :verify_store_info_plist do |options|
Comment thread
opficdev marked this conversation as resolved.
require "shellwords"
require "tmpdir"

ipa_path = options[:ipa]
expected_database_id = options[:database_id]
expected_function_api_base_url = options[:function_api_base_url]

UI.user_error!("Missing IPA path") if ipa_path.to_s.strip.empty?
UI.user_error!("Missing expected Firestore database ID") if expected_database_id.to_s.strip.empty?
UI.user_error!("Missing expected Function API base URL") if expected_function_api_base_url.to_s.strip.empty?
UI.user_error!("Missing built ipa at #{ipa_path}") if !File.exist?(ipa_path)

Dir.mktmpdir("devlog-ipa") do |tmpdir|
Expand All @@ -111,6 +129,19 @@ platform :ios do
end

UI.message("Verified FIRESTORE_DATABASE_ID=#{actual_database_id}")

actual_function_api_base_url = sh(
"/usr/libexec/PlistBuddy -c 'Print :FUNCTION_API_BASE_URL' #{Shellwords.escape(plist_path)}",
log: false
).strip

if actual_function_api_base_url != expected_function_api_base_url
UI.user_error!(
"Unexpected FUNCTION_API_BASE_URL: expected #{expected_function_api_base_url}, got #{actual_function_api_base_url}"
)
end

UI.message("Verified FUNCTION_API_BASE_URL=#{actual_function_api_base_url}")
end
end

Expand All @@ -119,10 +150,13 @@ platform :ios do
output_directory = options[:output_directory] || TESTFLIGHT_BUILD_OUTPUT_DIRECTORY
expected_database_id = options[:database_id] ||
(configuration == APPSTORE_CONFIGURATION ? APPSTORE_DATABASE_ID : TESTFLIGHT_DATABASE_ID)
expected_function_api_base_url = options[:function_api_base_url] ||
(configuration == APPSTORE_CONFIGURATION ? APPSTORE_FUNCTION_API_BASE_URL : TESTFLIGHT_FUNCTION_API_BASE_URL)

verify_store_configuration(
configuration: configuration,
database_id: expected_database_id
database_id: expected_database_id,
function_api_base_url: expected_function_api_base_url
)

if ENV["FASTLANE_XCODEBUILD_SETTINGS_TIMEOUT"].to_s.strip.empty?
Expand Down Expand Up @@ -212,9 +246,10 @@ platform :ios do
ipa_output_path = lane_context[SharedValues::IPA_OUTPUT_PATH].to_s
ipa_output_path = File.join(output_directory, "#{APP_PRODUCT_NAME}.ipa") if ipa_output_path.empty?

verify_firestore_database_id(
verify_store_info_plist(
ipa: ipa_output_path,
database_id: expected_database_id
database_id: expected_database_id,
function_api_base_url: expected_function_api_base_url
)

dsym_output_path = lane_context[SharedValues::DSYM_OUTPUT_PATH]
Expand All @@ -228,7 +263,8 @@ platform :ios do
lane :deploy_testflight do
build_for_store(
configuration: TESTFLIGHT_CONFIGURATION,
database_id: TESTFLIGHT_DATABASE_ID
database_id: TESTFLIGHT_DATABASE_ID,
function_api_base_url: TESTFLIGHT_FUNCTION_API_BASE_URL
)

upload_testflight_build
Expand All @@ -237,23 +273,26 @@ platform :ios do
lane :testflight_build_only do
build_for_store(
configuration: TESTFLIGHT_CONFIGURATION,
database_id: TESTFLIGHT_DATABASE_ID
database_id: TESTFLIGHT_DATABASE_ID,
function_api_base_url: TESTFLIGHT_FUNCTION_API_BASE_URL
)
end

lane :appstore_build_only do
build_for_store(
configuration: APPSTORE_CONFIGURATION,
output_directory: APPSTORE_BUILD_OUTPUT_DIRECTORY,
database_id: APPSTORE_DATABASE_ID
database_id: APPSTORE_DATABASE_ID,
function_api_base_url: APPSTORE_FUNCTION_API_BASE_URL
)
end

lane :deploy_appstore do
build_for_store(
configuration: APPSTORE_CONFIGURATION,
output_directory: APPSTORE_BUILD_OUTPUT_DIRECTORY,
database_id: APPSTORE_DATABASE_ID
database_id: APPSTORE_DATABASE_ID,
function_api_base_url: APPSTORE_FUNCTION_API_BASE_URL
)

upload_appstore_build
Expand All @@ -280,9 +319,10 @@ platform :ios do

UI.user_error!("Missing built ipa at #{ipa_output_path}") if !File.exist?(ipa_output_path)

verify_firestore_database_id(
verify_store_info_plist(
ipa: ipa_output_path,
database_id: TESTFLIGHT_DATABASE_ID
database_id: TESTFLIGHT_DATABASE_ID,
function_api_base_url: TESTFLIGHT_FUNCTION_API_BASE_URL
)

upload_to_testflight(
Expand All @@ -300,9 +340,10 @@ platform :ios do

UI.user_error!("Missing built ipa at #{ipa_output_path}") if !File.exist?(ipa_output_path)

verify_firestore_database_id(
verify_store_info_plist(
ipa: ipa_output_path,
database_id: APPSTORE_DATABASE_ID
database_id: APPSTORE_DATABASE_ID,
function_api_base_url: APPSTORE_FUNCTION_API_BASE_URL
)

upload_to_app_store(
Expand Down
Loading