[fix/recursive-fp-copy] Fix recursive copy in File Provider#1557
[fix/recursive-fp-copy] Fix recursive copy in File Provider#1557felix-schwarz wants to merge 3 commits into
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
|
Since this affect a complete feature of the app, a sanity test was done to check beyond the reported defect [WIP] 1. Copy from device to oC
2. Copy from oC to oC |
This comment was marked as outdated.
This comment was marked as outdated.
(1)That's probably kind of side-effect, not about this fix itself. I use to get an error (crash?) in the fp when copying from oC account as origin. My guess is that the error/crash happens when the file has to download first (required to upload the file to the target account via fp), because that step is skipped in the "local device → oC account" scenario. Video and logs caught: ScreenRecording_07-10-2026.13-17-08_1.MP4ownCloud_10_Jul_2026_at_13_15_29.log.txt (i found no crash log inside, so, i will let you better explore it) Unfortunately, this is not deterministic (idk what it depends on), but i can frequently reproduce it. Any input about this @felix-schwarz? thanks in advance |
… for folders (=> observed/expected behaviour by Files.app in iOS 26 when copying folder hierarchies)
- replace bookmark.uuid.UUIDString with bookmark.uuidString across the board - FileProviderExtension: - avoid race condition in -createDirectoryWithName:… by no longer returning early placeholders if online - ensure all OCItems returned to the OS contain their bookmarkUUID so that VFS Item IDs can be properly constructed, returned and resolved
283d672 to
667fba3
Compare
…ation) property documentSize as a workaround to fix a crash when dragging a space "root folder" onto another account's space "root folder" in Files.app
|
@jesmrec Thanks for (1). I've since been able to reproduce it and found the following:
It only occurs when using background Copying within the same account of folders generally appears to work just fine - regardless of whether the files in the folders already have a local copy or not. |
that's a technical one, i was not able to reproduce. Any clue @felix-schwarz ? About (1), fix has been deferred to #1568. So, i will test the remaining stuff there. |
Description
This PR fixes an issue where trying to copy and paste a whole folder hierarchy into the File Provider could render inconsistent and incomplete results.
Related Issue
https://kiteworks.atlassian.net/browse/SE-1082
owncloud/ios-sdk#162
Types of changes