Skip to content

[fix/recursive-fp-copy] Fix recursive copy in File Provider#162

Open
felix-schwarz wants to merge 2 commits into
masterfrom
fix/recursive-fp-copy
Open

[fix/recursive-fp-copy] Fix recursive copy in File Provider#162
felix-schwarz wants to merge 2 commits into
masterfrom
fix/recursive-fp-copy

Conversation

@felix-schwarz

@felix-schwarz felix-schwarz commented May 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR is the SDK counterpart for the fix/recursive-fp-copy PR in ios-app.

Related Issue

owncloud/ios-app#1557

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@felix-schwarz
- OCVaultLocation: fix vfsItemID for cases where only .vfsNodeID is n…
e6604be 
…ot set, but the node is still a virtual node (=> should have affected mostly drive-representing VFS nodes)
@felix-schwarz
- OCBookmark:
60d980b 
	- add new .uuidString property (including caching) to avoid OCBookmark.uuid.uuidString calls
	- switch from bookmark.uuid.UUIDString to bookmark.uuidString across the codebase
- OCSyncContext:
	- modernize syntax for private ivars
	- add new mechanism to add completion handler(s) to run after context actions have run
- OCSyncActionCreateFolder:
	- add bookmarkUUID to placeholderItem
	- run the placeholder completion handler only after the folder item has been added to the database
- OCVaultLocation: add debug description
- OCVFSCore: add (and comment out) verbose debug logging for resolution
@felix-schwarz felix-schwarz self-assigned this May 31, 2026
@felix-schwarz felix-schwarz mentioned this pull request May 31, 2026
Open
3 tasks
@dj4oC Claude

dj4oC commented Jul 8, 2026

Copy link
Copy Markdown

Automated note (code-analysis only, no build/test run in this environment): owncloud/ios-app#1557 already points its ios-sdk submodule at this branch's commit (60d980b), but this PR shows mergeable_state: behind — it has drifted from master. Since a submodule reference to an unmerged, moving feature branch is fragile (force-push/rebase here would silently break or change the app-side pin), recommend rebasing this onto current master and merging it before ios-app#1557 merges, then re-pointing that PR's submodule bump at the resulting master commit rather than this branch tip.

On the change itself: OCBookmark.uuidString is a straightforward lazily-cached wrapper over _uuid.UUIDString (invalidated only via initWithCoder: resetting it to nil) — no behavioral divergence from the old .uuid.UUIDString call sites found. The OCSyncContext addContextActionsCompletionHandler/runContextCompletionHandlers addition (deferring the OCSyncActionCreateFolder placeholder completion until after DB updates) is properly @synchronized-guarded and looks correct as the fix for the DB race mentioned on the app-side PR.

🤖 Automated review by Claude Code (security · stability · performance · coverage)

Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Matthias-Huehne-Kiteworks Matthias-Huehne-Kiteworks Matthias-Huehne-Kiteworks approved these changes
+1 more reviewer
@hosy hosy hosy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@felix-schwarz felix-schwarz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@felix-schwarz @dj4oC @hosy @Matthias-Huehne-Kiteworks @jesmrec