feat(tx-killswitch): 5-min cadence, TLS hardening, softer docs - #131
Merged
Conversation
Three changes: - Polling every 5 minutes instead of every minute. With hundreds of nodes the request rate against the publishing endpoint becomes trivial, while still pausing a misbehaving fleet within a single beacon cadence. Bumped staleness window from 10 to 30 minutes to preserve the "several poll cycles before declaring stale" semantics. - Harden TLS verification. The named "tx-kill-switch" HttpClient now pins a fresh SocketsHttpHandler with default SslOptions (system trust store, full chain / hostname / expiry validation). Means any future global tweak to the default handler - someone adding a "trust all" callback for testing and forgetting it - does not silently weaken the kill-switch fetch. Added a runtime guard in PollOnce that refuses to fetch over plaintext if the URL ever drifts off https://. .NET's default HttpClient already validates; this is belt-and-braces. - Softer wording in the docs. Drop the "or fork" / "the answer is to not run" framing, replace "gag" with "pause" / "silence" / "stop", reframe the rationale around "asking nodes to pause" rather than "every node, regardless of operator, polls". The substance is unchanged: still hardcoded, still not configurable, still removed before 1.0. Just less stark. Pin test updated for the new 300s / 1800s constants. Tests: 637/637. Manual smoke confirms the poller hits the live OARC URL over HTTPS using the pinned named-client handler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three changes to the dev-time TX kill-switch landed in #128/#129:
Test plan
🤖 Generated with Claude Code