chore(ci): remove old-arch template tests and stop on lint failure

[patrickkabwe]

Summary by CodeRabbit

Chores

• Simplified E2E test workflow execution—tests now run conditionally based on workflow dependencies rather than unconditionally.
• Streamlined Android and iOS build workflows—removed multi-architecture build configurations and transitioned to single-architecture builds.

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed unconditional execution guards from E2E jobs in the CI workflow and eliminated multi-architecture build matrices from Android and iOS template build workflows, simplifying job scheduling and standardizing to single-architecture builds.

Changes

Cohort / File(s)	Summary
E2E Jobs Configuration .github/workflows/ci-packages.yml	Removed if: always() guards from e2e-android and e2e-ios jobs, transitioning them from unconditional execution to standard workflow dependency-based scheduling.
Template Build Workflows assets/template/.github/workflows/android-build.yml, assets/template/.github/workflows/ios-build.yml	Removed matrix-based multi-architecture strategies, matrix configuration blocks, and conditional architecture-specific build steps, simplifying workflows to single linear build paths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• ci: unify package build with e2e and package-manager tests #332 — Modifies CI E2E and build workflow definitions with similar job behavior changes.
• chore(ci): refactor template android/ios workflows #329 — Modifies the same Android/iOS template workflow files and matrix/architecture handling that this PR removes.

Poem

🐰 Away with the always-runs, simplicity wins!
No more matrix mazes, just linear spins,
E2E jobs flow as conditions direct,
Clean workflows at last—a code-bundler's respect! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main changes: removing old-arch (matrix-based) builds from template workflows and relates to CI configuration updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch chore/ci-remove-old-arch-and-stop-on-lint-fail

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

assets/template/.github/workflows/android-build.yml (1)

37-71: LGTM — clean matrix removal; note the old-arch coverage trade-off.

The workflow is correctly simplified: the static job name on line 39 aligns with the removed strategy: matrix: block, and no stale ${{ matrix.arch }} references remain. The remaining steps (JDK 17/Zulu, Gradle cache, assembleDebug --no-daemon --build-cache) are standard and correct.

The intentional drop of the old-arch matrix means CI no longer validates the Old Architecture path for generated Android templates. Confirm this aligns with the project's minimum supported React Native version (i.e., the Old Architecture is no longer a support requirement).

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@assets/template/.github/workflows/android-build.yml` around lines 37 - 71,
The workflow removed the old-arch matrix but did not verify compatibility:
confirm the project’s minimum supported React Native version no longer requires
the Old Architecture and, if not, either restore the matrix (strategy: matrix
and references to ${{ matrix.arch }}) in the Build job or update project
metadata/docs to declare the minimum RN version that drops Old Architecture
support; check the Build job name "Build Android Example App" and any references
to old-arch in docs/config to locate where to change.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@assets/template/.github/workflows/android-build.yml`:
- Around line 37-71: The workflow removed the old-arch matrix but did not verify
compatibility: confirm the project’s minimum supported React Native version no
longer requires the Old Architecture and, if not, either restore the matrix
(strategy: matrix and references to ${{ matrix.arch }}) in the Build job or
update project metadata/docs to declare the minimum RN version that drops Old
Architecture support; check the Build job name "Build Android Example App" and
any references to old-arch in docs/config to locate where to change.

---

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 014e67b and 34739d6.

📒 Files selected for processing (3)

• .github/workflows/ci-packages.yml
• assets/template/.github/workflows/android-build.yml
• assets/template/.github/workflows/ios-build.yml

💤 Files with no reviewable changes (1)

• .github/workflows/ci-packages.yml