Skip to content

chore(ci): remove old-arch template tests and stop on lint failure #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickkabwe merged 1 commit into from
Feb 26, 2026
Merged

chore(ci): remove old-arch template tests and stop on lint failure #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/ci-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,6 @@ jobs:

# E2E tests (Android)
e2e-android:
if: always()
name: Android E2E Test
needs: generate-packages
runs-on: ubuntu-latest
Expand Down Expand Up @@ -445,7 +444,6 @@ jobs:

# E2E tests (iOS)
e2e-ios:
if: always()
name: iOS E2E Test
needs: generate-packages
runs-on: macOS-15
Expand Down
10 changes: 1 addition & 9 deletions assets/template/.github/workflows/android-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,23 +36,15 @@ concurrency:

jobs:
build:
name: Build Android Example App (${{ matrix.arch }})
name: Build Android Example App
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
arch: [new, old]
steps:
- uses: actions/checkout@v4
- uses: oven-sh/setup-bun@v2

- name: Install dependencies (bun)
run: bun install

- name: Disable new architecture in gradle.properties
if: matrix.arch == 'old'
run: sed -i "s/newArchEnabled=true/newArchEnabled=false/g" example/android/gradle.properties

- name: Setup JDK 17
uses: actions/setup-java@v5
with:
Expand Down
10 changes: 1 addition & 9 deletions assets/template/.github/workflows/ios-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,8 @@ concurrency:

jobs:
build:
name: Build iOS Example App (${{ matrix.arch }})
name: Build iOS Example App
runs-on: macOS-15
strategy:
fail-fast: false
matrix:
arch: [new, old]
steps:
- uses: actions/checkout@v4
- uses: oven-sh/setup-bun@v2
Expand All @@ -64,10 +60,6 @@ jobs:
- name: Install dependencies (bun)
run: bun install

- name: Disable new architecture in Podfile
if: matrix.arch == 'old'
run: sed -i "" "s/ENV\['RCT_NEW_ARCH_ENABLED'\] = '1'/ENV['RCT_NEW_ARCH_ENABLED'] = '0'/g" example/ios/Podfile

- name: Setup Ruby (bundle)
uses: ruby/setup-ruby@v1
with:
Expand Down